Fixes #4868: Move r32551 to v1.8 branch (configury: disable pshmem if buggy)

---svn-pre-commit-ignore-below---

r32551 [[BR]]
configury: disable pshmem if buggy compiler is detected

PGI compilers older that 2013 have a buggy preprocessor
that does not support pragma defined in a macro called
itself called from an other macro

cmr=v1.8.2:reviewer=jsquyres

r32590 [[BR]]
oshmem configury: tighten up the pshmem checks

Make the checks for macro weak symbols be equivalent to the checks for
weak symbols.

Also fix up several OSHMEM configure checks:

* fix an errant AC_MSG_REQUEST
* don't check for profiling ability during configure options checks.
  Instead, defer it to later, when we have weak symbol check results.
* don't directly call _FOO macros from the top level
* make setting up OSHMEM profiling similar to MPI profiling: create
  OSHMEM_SETUP_PROFILING macro
* cache the results of checking for macro weak symbols (for parity
  with the weak symbol check -- although we should really
  revisit/audit the whole cache-checking scheme throughout all m4
  code; it may well be inconsistently used)
* add some more [] m4 quoting, even in the original C weak symbols test
* style: fix some whitespace errors

Refs #4868

r32593 [[BR]]
oshmem configury: fix a typo

Fix a typo in r32590

Refs #4868

r32594 [[BR]]
oshmem configury: fix a test

Fix a test in r32590

Refs #4868
Fixes #4867: Move cuda cleanup code to v1.8

Cleanups applied from patch
Fixes #4862: Move r32529 to 1.8 branch (handling file view size of zero bytes)

---svn-pre-commit-ignore-below---

r32529 [[BR]]
fix the zero byte fileview problem reported by Mohamad on the mailinglist
Fixes #4861: Move r32522 to v1.8 branch (usnic: convert some BTL_ERRORs to)

---svn-pre-commit-ignore-below---

r32522 [[BR]]
usnic: convert some BTL_ERRORs to more descriptive show_help messages

1. After we receive N abnormally-short messages (meaning: corrupted),
print a show_help message about it.  N defaults to 25.  N can be set
to 0 disable the message via btl_usnic_max_short_packets.
1. If we receive a completion error for something other than a
receive, display a show_help message.

Reviewed by Dave Goodell.

CMR'ing to v1.8.3, but it will require a custom patch because of the
OMPI->OPAL BTL move.

cmr=v1.8.3
Fixes #4848: Move r32477 to v1.8 branch (opal_search_libs.m4: improvements from Dave Goodell's)

---svn-pre-commit-ignore-below---

r32477 [[BR]]
opal_search_libs.m4: improvements from Dave Goodell's review

Unfortunately, I didn't see Dave's review until CMR #4841 went in.
Oops.

This commit is a handful of minor m4 improvements to that original
r32447 commit.  It can go to v1.8.3, just to minimize drift between
trunk and v1.8.

Reviewed by Dave Goodell.

cmr=v1.8.3:reviewer=ompi-rm1.8
Fixes #4660: Move r31828 to v1.8 branch (pml/ob1: as per past RFC)

---svn-pre-commit-ignore-below---

r31828 [[BR]]
pml/ob1: as per past RFC bring the inline send optimization to
MPI_Isend.

I filed an RFC for this optimization some time back. It is a
relatively simple optimization. If the data associated with an
MPI_Isend can be put on the wire without allocating an MPI_Request
then do so. In this case we can legally return omp_request_empty
which will correctly indicate that the request is complete and that is
was not cancelled (these are the only requirements on send requests).

cmr=v1.8.3:reviewer=bosilca
Fixes #4662: Portals4/MTL hangs in c_get_accumulate test

---svn-pre-commit-ignore-below---

r32295 [[BR]]
This commit fixes #4662 - "Portals4/MTL hangs in c_get_accumulate test".

- Portals4/OSC was unable to acquire an exclusive lock due to an invalid
local address in the atomic operation.  This caused the reported hang.
- After fixing the hang, the test continued to fail because
ompi_datatype_is_contiguous_memory_layout() reports that MPI_EMPTY (the
origin datatype) is noncontiguous and Portals4/OSC does not support
noncontiguous datatypes at this time.  However, in this case the origin
count is zero so contiguous/noncontiguous is irrelevant.  Now we skip
the contiguous check if the count is zero.

cmr=v1.8.3:reviewer=regrant:subject=Fix for "Portals4/MTL hangs in c_get_accumulate test"
Fixes #4855: Move r32505 to v1.8 branch (opal_config_asm.m4: fix typo in output)

---svn-pre-commit-ignore-below---

r32505 [[BR]]
opal_config_asm.m4: fix typo in output message

Thanks to Paul Hargrove for spotting the typo.

cmr=v1.8.3:reviewer=rhc