Cc pdlogs 61

Updated after review comments for the ENT feature.  
Modified the messages to capitalize acronyms.  
Removed unnecessary whitespace.  
Added full stop to end of each part of the message.  
Actions are numbered if there is more than one action.  This separates the individual actions.
Separated the log definitions with a blank line to make them more readable.  
Ran astyle (according to the coding standards) against sprout_ent_definitions.h.
Fixed header file inconsistencies.
The review comment had: "A lot of the logs still say 'report issue to support' or something similar. This just isn't suitable for Project Clearwater."
The language was kept the same as this is what is done for the SNMP alarm definitions.  The associated documentation should identify the Metaswitch support team for ClearwaterCore and the Clearwater mailing list for Clearwater.
Removed signalnames.cpp.  The signal call name is now obtained from the strsignal call.
Fixed.

From: Eleanor Merry [mailto:notifications@github.com]
Sent: Thursday, December 18, 2014 11:40 AM
To: Metaswitch/sprout
Cc: David Collins
Subject: Re: [sprout] Cc pdlogs 61 (#895)


In include/sprout_ent_definitions.h<https://github.com/Metaswitch/sprout/pull/895#discussion-diff-22057336>:

> +  PDLogBase::CL_SPROUT_ID + 22,

> +  PDLOG_ERR,

> +  "The HTTP interfaces encountered an error when stopping the HTTP stack in %s with error %d.",

> +  "When the Application was exiting it encountered an error when shutting down the HTTP stack.",

> +  "Not critical as the Application is exiting anyway.",

> +  "Report the issue to support."

> +);

> +

> +static const PDLog2<const char*, const char*> CL_SPROUT_SIP_SEND_REQUEST_ERR

> +(

> +  PDLogBase::CL_SPROUT_ID + 23,

> +  PDLOG_ERR,

> +  "Failed to send SIP request to %s with error %s.",

> +  "An attempt to send a SIP request failed.",

> +  "This may cause a call to fail.",

> +  "(1). Check to see if the target has failed. "

I agree - I think that you should just have the second action, and not mention the target (e.g. If this problem persists check network connectivity)

—
Reply to this email directly or view it on GitHub<https://github.com/Metaswitch/sprout/pull/895/files#r22057336>.