Core: High-DPI support for output pane buttons

Replaced the style sheet and sub-widget by plain painting code. At the
same time achieveing high-DPI support by adding the @2x variants of the
border images.

Change-Id: I09804e3349b4650c7c6cfc2341913079a51a52a7
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
OutputPaneManager: Compile fix

Change-Id: Icb4dca2d814aebb1d55881a38294c955c515e1a4
Reviewed-by: hjk <hjk121@nokiamail.com>
TextEditor: Prevent overwriting of completion settings

This was a regression introduced during the editor setup refactoring.

Task-number: QTCREATORBUG-12982
Change-Id: I7b26b4105dfb50357dd2cf97d07153031d0b2dc0
Reviewed-by: Campbell Barton <ideasman42@gmail.com>
Reviewed-by: hjk <hjk121@nokiamail.com>
Core: Fix compile

Change-Id: I4910c6a8de05a7ceead5b25c877ec2892be4affd
Reviewed-by: Oliver Wolff <oliver.wolff@digia.com>
Editors: change QTC_CHECK to Q_ASSERT to prevent nullptr derefs.

When the check would fail, it would result in an nullptr deref 4 lines
down. As this is a constructor, doing a QTC_ASSERT(..., return) would
leave the object partially initialized, with some fields containing
random garbage.

Change-Id: I7e504f16f3bd07e3669c02773434915bc817c8bd
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
Help: fix possible nullptr deref.

Setting QTC_HELPVIEWER_BACKEND to "native" when the native backend is
not compiled in, would result in a nullptr deref.

Change-Id: I5618650e0c4ae1c986a54a46232e8f782e43f350
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
New Project Wizard: Fix displayname of "None" node on project selection

Was broken in 5969c01fa625fa41f0b45907c31c411792c4ffee.

Change-Id: I5e6e20ae8570e7c49cb87f429f6d65993fe4618e
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
Core: fix possible nullptr deref.

Change-Id: Iaa9182579afa19c9c8f184f964eeace3bc7b7906
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
Project Explorer: replace a QTC_CHECK with Q_ASSERT.

When the check would fail, it would result in a nullptr deref 3 lines
down. As this is a constructor, doing a QTC_ASSERT(..., return) would
leave the object partially initialized, with some fields containing
random garbage.

Change-Id: I823d52d43d90eaf06cb7d7cd64fbee17e5fc889e
Reviewed-by: Daniel Teske <daniel.teske@digia.com>
Qmake Project Manager: make QTC_ASSERT actually useful.

Change-Id: I0ca381dca2f7a50e3638f10c77db9b6621fb32c4
Reviewed-by: Daniel Teske <daniel.teske@digia.com>
File drag&drop: Move mime data creation to central place

Especially when this gets more complicated with additional fancy windows
mime types and custom mime type for opening a file at a specific
location (dropping from Outline, Type Hierarchy et al), we should not
create that complex mime data everywhere by hand.

Change-Id: I37f6ceb287b0cd055501fdd033ac29816434a020
Reviewed-by: Daniel Teske <daniel.teske@digia.com>
qmljs: make refactoring work on Object Bindings

“Move Component to Separate File” and “Wrap Component in Loader” did
work only for UiObjectDefinitions, extended them to UiObjectBindings.

Task-number: QTCREATORBUG-12904
Change-Id: I5216110c1edfc6e4536f83eba39e74919c918d50
Reviewed-by: Tim Jenssen <tim.jenssen@digia.com>
QML/JS editor: make QTC_ASSERT actually useful.

Change-Id: I32f2ee037b372c54ae41ea1b3626365e4f201118
Reviewed-by: Fawzi Mohamed <fawzi.mohamed@digia.com>
QML: prevent nullptr deref by returning when we detected an error.

Change-Id: I46d351e517d575bff158a4c9e785645462023ae9
Reviewed-by: Fawzi Mohamed <fawzi.mohamed@digia.com>
QML/JS: fix improbable nullptr deref in possible future use.

The ast parameter cannot be null, because the only use checks for it not
to be null. However, if it would ever be re-used somewhere else, the
logic is plain wrong. Clarification by an assert makes it clear what the
intent is.

Pointed out by the clang static analyzer.

Change-Id: I2c8cba5e5847fc1f92c10021109c55ff8ccd58c4
Reviewed-by: Fawzi Mohamed <fawzi.mohamed@digia.com>
Revert "C++: add support for resolving typedefs for template arguments"

This reverts commit c228b36ccf92f3a75d7687159d99da496cf5e241.

There are multiple issues with the reverted patch:
  * Infinite loop due to indirect recursion e.g. when opening projectmodels.cpp
  * Crash when executing CppTools tests on Windows (no infinite loop)

Change-Id: I38f02132ca57d3d32085db6146d0df7d620d7618
Reviewed-by: Erik Verbruggen <erik.verbruggen@digia.com>
ValgrindFake: prevent clang static analyzer alarm bells.

The divide by zero is intentional, so suppress the not-quite-so-false
positive from appearing.

Change-Id: Iba96682e5b584a7e4a8e5895af0ccfc68b73cc71
Reviewed-by: hjk <hjk121@nokiamail.com>
Debugger: remove dead stores.

The dead stores are not harmfull, but add noise when checking for dead
stores that are due to logic errors.

Change-Id: I8bf61c51207f0339911bc07fcfbc06f8066521e5
Reviewed-by: hjk <hjk121@nokiamail.com>
CDB: prevent possible nullptr deref.

Change-Id: I111b4620effc45f26f40880875a70d606c924f69
Reviewed-by: hjk <hjk121@nokiamail.com>
BlackBerry: Work around over-eager -Wmaybe-uninitialized

Change-Id: I701d01a935bdbb65808de65cf2a994a5d68cf1d4
Reviewed-by: Erik Verbruggen <erik.verbruggen@digia.com>