Brocade mechanism driver should be derived from ML2 plugin base class

Change-Id: Iddcb6a43d60d5c9f472912efdecbb2aaa9b7ea4a
Fixes-bug: #1327001
Ignore emacs checkpoint files

Change-Id: Ie9870cded34e97c078b0f376948c6b6bc6ac2eb4
Updated from global requirements

Change-Id: I321a9db3ff1082e226f9cf8d831c287c64d871f9
Imported Translations from Transifex

Change-Id: I2dcf35f9af679fd64258bfef19e105956c7d5e90
NSX: revert queue extension name change

The following patch: d7aa2dfcb14b84e2ef3242fb0787200d852d6103 renamed the
nvp-qos extension to qos-queue which breaks the integration with nova as
nova checks for the nvp-qos extension to be loaded and now it's called
qos-queue. This patch adds back nvp-qos for trunk chasers and another
patch will migrate nova from nvp-qos to qos-queue.

Change-Id: I563aed6b6c4551489989f846a619d54020d0b5ee
closes-bug: 1329071
remove pep8 E122 exemption and correct style

This change removes the E122 exemption for pep8. E122 is "continuation line missing indentation or outdented"

Change-Id: I4bd1e6c787648a3dfa69b514efeeff05996aabc1
Partial-Bug: 1329017
Imported Translations from Transifex

Change-Id: I5a8f588c2f10d974d167f9fb1601ae1d3f231238
Port to oslo.messaging

Now that all preparations are done, actually port the code to use
oslo.messaging. This patch does as little as possible. Follow up patches
that refactor and cleanup the code and configuration files, will be
merged later. The reason for this is to make the patch as slim as
possible, to make review process more smooth and concentrated.

Details:
* neutron/common/rpc.py:
  - added init() and cleanup() to set global RPC layer state.
  - added utility functions: get_server(), get_client(), get_notifier()
    that wrap up oslo.messaging API a bit, enforcing eventlet executor
    and setting serializer, among other things.
  - removed PluginRpcDispatcher, instead introduced PluginRpcSerializer
    to use as a default serializer for API callbacks.

* neutron/common/rpc_compat.py:
  - emulated incubator RPC layer behaviour thru previously introduced
    stub classes (RpcCallback, RpcProxy, ...) using new oslo.messaging
    API.
  - switched to using new oslo.messaging exception types.

* neutron/service.py:
  - expect multiple RPC listeners that are of MessageHandlingServer
    type, not GreenThread.

* neutron/common/config.py:
  - initialize RPC layer in init()

* setup.cfg:
  - added entry points for old notifier drivers to retain backward
    compatibility.

* neutron/tests/...:
  - introduced fake_notifier to replace impl_fake.
  - faked out consume_in_thread() to avoid starting RPC listeners when
    running unit tests.
  - used 'fake' transport driver.
  - made sure neutron.test.* exceptions are caught.
  - initialize and clean up RPC layer for each test case.

* Ported all affected code from using neutron.openstack.common.notifier
  API to oslo.messaging.Notifier.

* rpc.set_defaults() was renamed to rpc.set_transport_defaults()

* other changes not worth mentioning here.

blueprint oslo-messaging

DocImpact

Change-Id: I5a91c34df6e300f2dc46217b1b16352fcc3039fc
Renamed start_rpc_listener -> start_rpc_listeners

Now that we explicitly start multiple RPC servers, renamed the method to
reflect behaviour.

blueprint oslo-messaging

Change-Id: I7c51cc1b44b4b4c8899255b9bedce1792c38634e
Renamed consume_in_thread -> consume_in_threads

Now that we explicitly start multiple RPC servers, and each listener is
served in a separate thread, renamed the method to reflect new
behaviour.

blueprint oslo-messaging

Change-Id: I616f3a23e23e982e13f9b56ce417ca3623247f95
Renamed argument for create_consumer[s]

Now that we don't have explicit dispatcher class to pass into RPC layer,
and we pass a list of endpoints instead, fix names for corresponding
arguments of the functions.

blueprint oslo-messaging

Change-Id: I84c6428574c155cdfaf535210b236c58604de268
NSX: propagate network name updates to backend

This patch updates the logical switch name on the NSX backend
if a new network name is provided in the update request.

This patches also fixes tag management for update_lswitch in
neutron.plugins.vmware.nsxlib.switch and add relevant unit
tests.

Closes-Bug: 1276128
Change-Id: Ic8921c059012a875006701ac10d2dcae97f30253
Allowed address pair: Removing check for overlap with fixed ips

Some of the overlap check has been removed in the following patch:
https://review.openstack.org/#/c/94508/
But the patch did not remove all the overlap check. I remove the
rest part.

Change-Id: I575ec54c0b3d6dc31ef80819d4258c6d162b4cfd
Closes-Bug: #1326007
Fix NVP FWaaS occurs error when deleting a shared rule

It is due to the lack of edge_id query index  when deleting the
vcns_edge_firewallrule_binding entry, which leads to deleting
rule binding entrys on both edges.
Closes-Bug: #1322105

Change-Id: I1d15a06bd2a6c42f29c8258d4b9344c8e9338638
Revert "ovs-agent: Ensure integration bridge is created"

This reverts commit e5cdad90f97d3a54a493eca19e7a3ff643426de1.

TripleO's multi-node testing shows that this patch caused a failure to receive
tunnel updates, leading to the first node up to have no agent ports, the second
to have one agent port, the third to have 2 agent ports, etc. Needless to say,
this doesn't work all that well :)

Change-Id: Ie90dd4d113a404948dd5debad48065b7db48faa5
Closes-Bug: #1292105
Remove old quantum scripts

This patch removes some old scripts left behind from the quantum days.

Change-Id: I73fb702272e6b93df9ec145da380da88c27259c8
Closes-Bug: #1331664
Check port value when creating firewall rule with icmp protocol

If a firewall rule was created with setting protocol as icmp
and using source/destination port no error was thrown, even though
source/destination port parameters are not used by icmp.

This patch adds a validation method that checks passed parameters
and throws an exception if they are incompatible.

Change-Id: I90a765856896395fcb6e9ddbd888b7bd80480674
Closes-Bug: 1327955
Pass 'top' to remove_rule so that rule matching succeeds

When deleting a vpn-site-connection, deleting the nat rule would
fail because it was created with top=True, but top defaults to
'false' in remove_rule and was not being passed. This caused the
rule matching to fail and the rule to not be deleted.

Change-Id: I51012a783314c97e85b31fc8a73be4cbb8ee7dc5
Closes-Bug: #1331839
Imported Translations from Transifex

Change-Id: I6b7e125163c2de03344f7c7f017b9171ebb6c2c9
Removed create_rpc_dispatcher methods

Now that we don't have a special dispatcher class and we pass a list of
endpoints to corresponding functions instead, those methods are
unneeded.

blueprint oslo-messaging

Change-Id: If2b187fd8e553594212264f34b51b5b99c4630b2