Store line numbers disabled/enabled via inline comments

Change-Id: Icb23881a9e86dc8039f3806875c645943caa7e7f
Reviewed-on: http://gerrit.causes.com/44951
Tested-by: jenkins <jenkins@brigade.com>
Reviewed-by: Shane da Silva <shane.dasilva@brigade.com>
Clean up ControlComments module

Convert some of the Ruby in this file to be more idiomatic.

Change-Id: Icd7ec38f422d4dccba9edbcfcd4f25e1fe4bb89c
Reviewed-on: http://gerrit.causes.com/44952
Tested-by: jenkins <jenkins@brigade.com>
Reviewed-by: Shane da Silva <shane.dasilva@brigade.com>
Convert ControlComments module into helper class

Using a module for this functionality is a bit of a smell as we're
simply pulling out the functionality into a separate file rather than
isolating concerns.

Changing this class to a helper class removes the dependency on
understanding the `Linter` class internals and instead only interacts
with the `Linter` class's public interface.

It also removes the need for multiple invocations of the
`initialize_vars` method, as we can now do that one time in the
constructor.

Change-Id: Ie6a2efb5921d6f13688e8b5198ebfe614584d7d0
Reviewed-on: http://gerrit.causes.com/44953
Tested-by: jenkins <jenkins@brigade.com>
Reviewed-by: Shane da Silva <shane.dasilva@brigade.com>
Deduplify TrailingZero and LeadingZero linters

Perhaps a silly change, but our CodeClimate score is being affected by
the apparent duplication in these two classes. Rename some variables to
see if we can fix that.

Change-Id: I3ea6eaa016a954ee745e893a5ff325bdaae9af15
Reviewed-on: http://gerrit.causes.com/44954
Tested-by: jenkins <jenkins@brigade.com>
Reviewed-by: Shane da Silva <shane.dasilva@brigade.com>
Extract helper from merge_wildcard_linter_options

This method was complex. Simplify it a bit by extracting a helper
method `linter_names_matching_glob`.

Change-Id: I4bede82fb4fc64041576055d34246fefac5efb4a
Reviewed-on: http://gerrit.causes.com/44955
Tested-by: jenkins <jenkins@brigade.com>
Reviewed-by: Shane da Silva <shane.dasilva@brigade.com>
Extract additional helper from merge_wildcard_linter_options

Change-Id: I8ecbe8c3a94c39e05e03ccd721da44280c770128
Reviewed-on: http://gerrit.causes.com/44956
Tested-by: jenkins <jenkins@brigade.com>
Reviewed-by: Shane da Silva <shane.dasilva@brigade.com>