worked on modals