fix in table related to defining protected variable with underscore
Fix in test case due to core changes of making variable protected
Merge pull request #4409 from garima-agal/Bug-table-Branch-Issue

fix in table related to defining protected variable with underscore
Prepare 3.3.6 hotfix
Reset for development
[fix] Status of modules : missing pending and expired. Fixes #4419

Fix to Brian request : https://github.com/joomla/joomla-cms/issues/4414
<pre>
Create a module with an end publishing date in the PAST. In the module list there is no visible change to its publishing status. It is still green. If you check an expired article you will see that the icon in the article list is orange not green to indicate it has expired.
</pre>
[imp] Removes self-linking article title. Fixes #4402

Signed-off-by: Seth Warburton <seth@internet-inspired.com>
[imp] Add collapsible sidebar. Fixes #4197

Move button before searchbox

Add tooltip

Fix remembering state. Simplify language string.

Layout fixes.

Updated icons, made them state aware. Updated language strings, made them state aware.

Updated icons, alpha ordered language file, added grey background to the sidebar.

Make the code abstract

Added check if localStorage is available. Added code change to compressed core.js.

Added toggle button to all views. Generated CSS files based on less generator.

Fixed toggle buttons on user views. Update template-rtl.less.

Fixed toggle button being activated on enter in filter field.

Moved button to the sidebar file. Added transition changes.

Cleanup banners

Cleanup banners

Further cleanup

Further cleanup

Simplify hiding the sidebar

Keep the button visible

Add missing empty line

Updated the sidepanel. Many thanks to @RemcoJanssen

Fixed Plugin view using the wrong div ID

Updated CSS for RTL languages

Change the icons used for closing and opening.

Updated CSS for RTL.
Merge remote-tracking branch 'staging' into 3.4-dev

Conflicts:
	administrator/manifests/files/joomla.xml
	libraries/cms/version/version.php
[imp] Routing: Introducing unittests for core app router classes. Fixes #3759

Introducing more unittests for the application router classes

Improve DI aspect

Update doc block

Add mocking for getMenu method

Use getMockCmsApp

Keep code style consistent

Fixing Unittest

Splitting getInstance tests for exceptions

Adding further tests for JRouter

Implementing unittest for JRouterSite::build

Fixing JRouter test,
fixing JRouter,
adding mock methods to JMenu Mock

More unittests

Fixing JRouter Tests

Try setting the default server vars

Fix build expected results

Cleaning up tests

More cleanup

Removing const's

Fixing unittests... again...

Replacing JApplication with JApplicationCms

Finalising Unittests for JRouter and its child-classes

Update router.php

Update site.php

Update application.php

Update menu.php

Update JApplicationHelperInspector.php

Update JRouterAdministratorTest.php

Update JRouterSiteTest.php

Update JRouterAdministratorTest.php

Update JRouterTest.php

Update JRouterInspector.php

Update JRouterSiteInspector.php

Update JRouterSiteTest.php

Fix Travis

FILE: /home/travis/build/joomla/joomla-cms/libraries/cms/router/site.php

--------------------------------------------------------------------------------

FOUND 1 ERROR(S) AFFECTING 1 LINE(S)

--------------------------------------------------------------------------------

413 | ERROR | Expected 2 spaces after the longest type

--------------------------------------------------------------------------------