ADS: Added KeepAlive Settings to the ApplePush Channel to aid with Azure...

... hosting.

I didn't add it to IPushChannelSettings as GCM doesn't maintain a socket connection and I don't have prior knowledge of the other channels to implement.

Hope you find it useful. The defaults are 20 mins and 30 secs as per the hardcoded values.

Cheers
You are absolutely correct - it's not the first time I've been caught out with that!

----------------------------------------
 From: "Jonathan Dick" <notifications@github.com>
Sent: Friday, October 17, 2014 2:41 PM
To: "Redth/PushSharp" <PushSharp@noreply.github.com>
Subject: Re: [PushSharp] ADS: Added KeepAlive Settings to the ApplePush Channel to aid with Azure... (#335)

In PushSharp.Apple/ApplePushChannel.cs: > @@ -487,7 +487,7 @@ void connect() >  								//client.Client.SetSocketOption(SocketOptionLevel.Socket, SocketOptionName.KeepAlive, true); >   >  								//Really not sure if this will work on MONO.... > -								try { client.SetSocketKeepAliveValues(20 * 60 * 1000, 30 * 1000); } > +								try { client.SetSocketKeepAliveValues(appleSettings.KeepAlivePeriod.Milliseconds, appleSettings.KeepAliveRetryPeriod.Milliseconds); }  

Don't you want this to be .TotalMilliseconds for both cases? -
Reply to this email directly or view it on GitHub.