Remove all references to lvm_vg_blacklist and blacklistVG.

They seem to have no purpose anymore.

This was prompted by a 'Using global for' pylint error.

Signed-off-by: mulhern <amulhern@redhat.com>
Obvious fix inspired by an "Undefined variable warning"

Signed-off-by: mulhern <amulhern@redhat.com>
Remove unnecessary lambda wrappers on assertion functions

Signed-off-by: mulhern <amulhern@redhat.com>
Make sure _state_functions is a dictionary in base class

Signed-off-by: mulhern <amulhern@redhat.com>
Use self.nic instead of nic

They are guaranteed to be identical, and nic's only real purpose is to be a
loop variable.

Prompted by a false positive W0631 error.

Signed-off-by: mulhern <amulhern@redhat.com>
Suppress false positive W0631 error.

The only way the else branch is not executed is if the break statement is
encountered. Since the else branch exits the only way this line can be
reached is if the break statement is encountered. But for the break
statement to be encountered, enumerate lines must be non-empty, and
therefore i,l must have been assigned to when the line is reached.

Not putting in pylint-false-positives because this may prove to be beyond
the scope of the W0631 analysis.

Signed-off-by: mulhern <amulhern@redhat.com>
Make LabelingAsRoot class an abstract class and define two properties

This gets rid of a lot of "has no '<field>' member" pylint errors where
<field> in { _fs_class, _invalid_label }.

Signed-off-by: mulhern <amulhern@redhat.com>
Add a bunch of E1120 errors to the false positives file

The analysis does not detect correctly that raid.RAID* refers to a singleton
object, rather than a class. I believe that this ought to be in the scope
of the analysis and so expect to remove these false positives when the analysis
is fixed.

Signed-off-by: mulhern <amulhern@redhat.com>
Ignore E1101 errors in savePassphrase.

E1101 does not handle instances of name-mangling of private fields correctly.

Signed-off-by: mulhern <amulhern@redhat.com>