On 02/07/2014 02:48 PM, Eric Leblond wrote:
> In src/util-host-info.c:
> 
>> +    }
>> +
>> +    ret = pcre_exec(version_regex, version_regex_study, kuname.release,
>> +                    strlen(kuname.release), 0, 0, ov, MAX_SUBSTRINGS);
>> +
>> +    if (ret < 0) {
>> +        SCLogError(SC_ERR_PCRE_MATCH, "Version did not cut");
>> +        goto error;
>> +    }
>> +
>> +    if (ret < 3) {
>> +        SCLogError(SC_ERR_PCRE_MATCH, "Version major and minor not found (ret %d)", ret);
>> +        goto error;
>> +    }
>> +
>> +    pcre_get_substring_list(kuname.release, ov, ret, &list);
> 
> I've just checked for introduction time of this function. I was
> introduced with pcre 6.0 in 2007. It is a bit old so I don't think this
> should be an issue for users. Do I convert the code to
> pcre_copy_substring anyway ?

I think it can stay this way then.