[BUGFIX] Run scheduler from cli fails on DBAL

With activated DBAL, dispatching the scheduler from cli
currently fails. The SqlParser can't handle brackets
in an ON-clause, so remove them in the query.

Resolves: #57246
Releases: 6.2
Change-Id: I2efa92392d22c854dae925da9a2396ef08bae198
Reviewed-on: https://review.typo3.org/28805
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
[BUGFIX] Fix initial file import in EM

The path calculation of the source path contains
double slashes, which is an invalid path for
the isAllowedAbsPath check, thus no files
are copied.

Resolves: #57312
Releases: 6.2
Change-Id: I1840cfe580efbdbeedd94c8a7e5469b94e70fa30
Reviewed-on: https://review.typo3.org/28802
Reviewed-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Francois Suter
Tested-by: Francois Suter
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
[BUGFIX] Check WorkspaceEnabled for MM field related table

If you try to edit a MM field associated to a table which doesn't use
versioning (t3ver_* fields are missing) you get a database error.
This patch adds a check if versioning for the table is enabled.

Resolves: #57291
Releases: 6.2
Change-Id: I3fc5dfeb77ce9a67a6e4494a3b2247c3007d0d25
Reviewed-on: https://review.typo3.org/28783
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
[BUGFIX] Load adminPanel styles for FE editing

This patch enables frontend editing even if the adminPanel is closed
(minimized). Before adminPanel AND editing tab have to be opened which
isn't really user-friendly.

Resolves: #55896
Releases: 6.2
Change-Id: I892fe72380c3ede326f3da708dd5d495667eb09e
Reviewed-on: https://review.typo3.org/27557
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Pascal Dürsteler
Tested-by: Pascal Dürsteler
Reviewed-by: Xavier Perseguers
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
[BUGFIX] Install tool update wizards show html tags in error message

The RteFileLinksUpdateWizard, RteMagicImagesUpdateWizard
and TceformsUpdateWizard convert there error messages to
FlashMessages. But as the messages are now always wrapped in a
flashmessage tag in the template this isn't needed anymore.

Resolves: #57285
Releases: 6.2
Change-Id: Iada05effdc523d24726ec54c2ad017175be4451f
Reviewed-on: https://review.typo3.org/28760
Reviewed-by: Philipp Gampe
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Markus Klein
Tested-by: Markus Klein
[BUGFIX] Install Tool-FAL metadata migration fails for big sets

In install tool there is migration script that copy part of sys_file
into sys_file_metadata. For long data sets (tested with 20.000 sys_file)
this update scripts returns FAIL.

Inserting using
https://dev.mysql.com/doc/refman/5.1/de/insert-select.html
overcomes all problems.

Resolves: #57103
Releases: 6.2
Change-Id: I1d2b97565f52bdd168f50651f285023f153fb3be
Reviewed-on: https://review.typo3.org/28580
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
Reviewed-by: Markus Klein
Tested-by: Markus Klein
[BUGFIX] Add correctly escaped css selectors for js

Because identifiers in css are using escaped entries, we
have to do another escaping for the javascript selectors.

Resolves: #56874
Releases: 6.2
Change-Id: Ie470def83409904963e8b6e89635a6734bc4088c
Reviewed-on: https://review.typo3.org/28522
Reviewed-by: Pascal Dürsteler
Tested-by: Pascal Dürsteler
Reviewed-by: Markus Klein
Tested-by: Markus Klein
[BUGFIX] Check default salting method first

Prioritise default salting hashing method when determining
the salting hashing method of a given salted hash.

Fixes rare cases when the method "isValidSaltedPW()" returns TRUE
for similar salting implementations.

Resolves: #54833
Releases: 6.2
Change-Id: I58eb214f171de9f285a7818edebd925eb8164888
Reviewed-on: https://review.typo3.org/26692
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Jigal van Hemert
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
[BUGFIX] CSC: file references not working with image compression

When using image compression with CSS styled content
all existing data in the $imgConf array is emptied.
If using a sys_file_reference, the file object
for resolving the file data does not consider
the option "treatIdAsReference" anymore as
it is unset as well.

How to reproduce: Add a file and select any image compression.
The wrong image is rendered, as the file UID is used
not the file reference UID.

If you have a sys_file UID 23, and a sys_file_reference ID 45
then the sys_file 45 is displayed instead of sys_file 23.

Releases: 6.2, 6.1
Resolves: #57346
Change-Id: Id503510b82df7bb4be9d236a1640322c92ffa5ec
Reviewed-on: https://review.typo3.org/28856
Reviewed-by: Tom Ruether
Tested-by: Tom Ruether
Reviewed-by: Wouter Wolters
Reviewed-by: Marc Bastian Heinrichs
Reviewed-by: Frans Saris
Tested-by: Frans Saris
[BUGFIX] Update for sys_file_metadata returns SQL error

Due to a missing space in front of the FROM part, the SQL statement
currently errors and the meta data for files can't be split up.

Resolves: #57420
Releases: 6.2
Change-Id: I58aa0e20621e3e0d44028774452267dc0746a148
Reviewed-on: https://review.typo3.org/28944
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
[BUGFIX] Extension update fails if needed by other extensions

On update process the extension which should be updated gets
uninstalled. This doesn't work if the extension is needed by other ones.
This patch removes the unload process before the update to make sure
system is working in the mean time.

Resolves: #57264
Releases: 6.2
Change-Id: I6f54cf8ba977e9c8038790ea3857ba6fff61a5f9
Reviewed-on: https://review.typo3.org/28883
Reviewed-by: Cedric Ziel
Tested-by: Cedric Ziel
Reviewed-by: Markus Klein
Tested-by: Markus Klein
[TASK] Cleanup ChangeLog from duplicate lines

Releases: 6.2
Change-Id: I360c4ce290735ea76fe48e003a47e867bf5cf85b
Reviewed-on: https://review.typo3.org/28952
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
[BUGFIX] Enable backend login for Internet Explorer 8 users

Due to some mystical IE8 behavior the global TYPO3 object gets reset
if any "var" occurs in Javascript. It is not necessary if its called or
not but it seems IE8 creates a new object. This patch adds the global
initialization of the TYPO3 object by using window[] syntax.

Resolves: #56988
Releases: 6.2
Change-Id: I5ce246790d1e3a1e388f106d085c96dae4e4304e
Reviewed-on: https://review.typo3.org/28929
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Markus Klein
Tested-by: Markus Klein
[BUGFIX] Respect config.debug setting for displaying parsetime

2 possible information snippets can be outputted using
config.debug = 1 in TypoScript or [FE][debug]=1 in Install Tool.

- Parsetime
- Cached page generated time + expire date

TypoScript should override the general setting of the Install Tool
to make it possible to turn debugging of for specific PAGE objects.

This is especially needed if using e.g JSON output is invalid
having this information.

The change uses the same check as in index_ts where it works perfectly
fine.

Change-Id: I1520896476d97286627ab7f3b232b733dd3c50f7
Resolves: #57365
Releases: 6.2
Reviewed-on: https://review.typo3.org/28909
Reviewed-by: Helmut Hummel
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
[TASK] Remove space in Page module notification

The page module's notification on sysfolders to switch to list view
got an extra line which can be removed.

Resolves: #57449
Releases: 6.2
Change-Id: I3c646b1f4a258924ca46652eae7c3f60391f52ac
Reviewed-on: https://review.typo3.org/28968
Reviewed-by: Felix Kopp
Tested-by: Felix Kopp
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
[TASK] Web>Page Search: Remove duplicate CSS

Due to centralized standard styles for standard elements no
further special CSS definition is necessary.

Also removes an excessive closing bracket in CSS.

Resolves: #57451
Releases: 6.2
Change-Id: I54d1bacce4774a7cc6924870985cb747cc3b5a89
Reviewed-on: https://review.typo3.org/28972
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
[BUGFIX] Allow user defined locales to work with TSFE->sL()

TYPO3 uses a list of "known" languages defined in
TYPO3\CMS\Core\Localization\Locales.

This list can be extended by the user, but these changes
are not taken into account when using
$GLOBALS['TSFE']->sL() to fetch the translation.

Make TypoScriptFrontendController call the needed method
"initialize()" to make it work.

Resolves: #53973
Releases: 6.2, 6.1
Change-Id: I9fc80ba976bf796f272591ac741d8bf4e92cbeb3
Reviewed-on: https://review.typo3.org/25685
Reviewed-by: Wouter Wolters
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
[BUGFIX] Remove the need of PackageStates.php in tests

Although there is code in the package manager tests
to mock a PackageStates.php file, it does not work
as the path to the file is hardcoded in the initialize
action.

Move the code for setting the path and creating
the package factory to the constructor
and move the mocking of the path before initializing
in the test.

Resolves: #57490
Releases: 6.2
Change-Id: I2ca29016de288017ec73ff36d0dbed1e2be0e67d
Reviewed-on: https://review.typo3.org/29021
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Thomas Maroschik
Reviewed-by: Stefan Neufeind
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
[BUGFIX] Backup of LocalConfiguration.php missing on update

If you update from a 6.x installation there should be a backup of the
old, unmodified LocalConfiguration.php as it's getting changed during
PackageStates.php extraction. This is prevented with commit e755bcd
as a check for the PackageStates.php file was introduced, which might
not be available at this point during upgrade.

Resolves: #57458
Releases: 6.2
Change-Id: Ic3634ab58e3e4112df5d8544cca9c42e8f1db91f
Reviewed-on: https://review.typo3.org/28980
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
[BUGFIX] Check if lock directory is writable

We should check if directory is writable. Else fopen in acquireLock
would only fail with error after waiting time. Also we do not aspect
write permission issue here.

Resolves: #57463
Releases: 6.2
Change-Id: Ia767a2355aecf1e816d4c130b151443e50e1a311
Reviewed-on: https://review.typo3.org/28988
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind