fix wrong printf format mismatches

As the title said this hunts all printf format mismatches (thanks @notspiff)
c standard says that the extra argument is to be ignored (after being 
evaluated), and adding 5 lines of code just to make gcc not spew a 
warning isn't okay imo. will look into it later, working now, just 
ignore this one for now please.

On 30-09-14 11:20, Sascha Woo wrote:
>
> In xbmc/peripherals/devices/Peripheral.cpp:
>
> > @@ -55,10 +55,16 @@ CPeripheral::CPeripheral(const PeripheralScanResult& scanResult) :
> >  {
> >    PeripheralTypeTranslator::FormatHexString(scanResult.m_iVendorId, m_strVendorId);
> >    PeripheralTypeTranslator::FormatHexString(scanResult.m_iProductId, m_strProductId);
> > -  m_strFileLocation = StringUtils::Format(scanResult.m_iSequence > 0 ? "peripherals://%s/%s_%d.dev" : "peripherals://%s/%s.dev",
> > -                                          PeripheralTypeTranslator::BusTypeToString(scanResult.m_busType),
> > -                                          scanResult.m_strLocation.c_str(),
> > -                                          scanResult.m_iSequence);
> > +
> > +  if (scanResult.m_iSequence > 0)
> > +    m_strFileLocation = StringUtils::Format("peripherals://%s/%s_%d.dev",
> > +                                            PeripheralTypeTranslator::BusTypeToString(scanResult.m_busType),
> > +                                            scanResult.m_strLocation.c_str(),
> > +                                            scanResult.m_iSequence);
> > +  else
> > +    m_strFileLocation = StringUtils::Format("peripherals://%s/%s.dev",
> > +                                            PeripheralTypeTranslator::BusTypeToString(scanResult.m_busType),
> > +                                            scanResult.m_strLocation.c_str());
>
> sure, you want to reduce lines of code we need for this special case, 
> but IMO it's cleaner and don't print the warning. we have different 
> opinions here ;)
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/xbmc/xbmc/pull/5408/files#r18206718>.
>