[split]  allow trailing comma at the end of a map

RB_ID=169872
[split] scrooge: rename Service$ThriftServer to Service$OstrichThriftServer - fixes breakage under scala 2.10 - also removed ostrichService.java which wasn't used

Once https://reviewboard.twitter.biz/r/172503/ merges, we can probably remove the ostrich code gen altogether.

RB_ID=172506
[split] scrooge-ostrich: search harder for FutureIface The code used in OstrichThriftServer to look for the FutureIface trait was only searching the interfaces of immediate class, but we also need to search superclasses and super-interfaces for when FutureIface is mixed in higher up.

RB_ID=172899
[split] Allow default struct values in the java generator.

RB_ID=172607
[split] Make scrooge plugin find thrift files in idls when run only with reactor projects in a clean env

RB_ID=173004
[split] Need to filter out items that are not set when rendering default struct values.

RB_ID=173158
[split] scrooge: support the scala namespace

RB_ID=173147
TBR=true
[split] Revert "scrooge: support the scala namespace"

This reverts commit 7401a4eee4cec9925e40a3ec111e57a0ee762532.

Fails to compile.

RB_ID=173859
TBR=true
NO-QUEUE=true
[split] scrooge: add support for scala namepsace

RB_ID=174164
[split] Fixup java codegen issues surfaced by converting ads:ad-review-tests in science to scrooge.

Fixup filename generation such that the extensionless basenames are always equal to the top level type name in the file.
Fixup string encoding to use valid escape sequences for java and further exactly match the apache thrift java generator escaping.

RB_ID=173957
[split] scrooge: fixed whitespace eating in strings ThriftParser extends RegexParsers.  RegexParsers calls a whitespace parser before each sub-parser, to automatically consume and discard whitespace.  The stringLiteral parser was composed of 3 sub-parsers, start quote, body, and end quote, which means the whitespace parser was getting invoked after the start quote and before the end quote.  This means whitespace within a string would get eaten, and if that whitespace was a line comment, the ending quote would get gobbled up as part of the line comment.  The fix is to use a single regex to match the entire string, quotes and all, and then strip the quotes off after the match.

While working in this code, I also switched most of the 'defs' to 'lazy val's, which should speed up the parser (not that this a big concern).  Straight 'vals' don't always work because of forward references.

RB_ID=174221
[split] bump scrooge to 3.6.1-SNAPSHOT

RB_ID=174427
TBR=true
Merge branch 'tmp'
[split] remove use of deprecated generated ostrich ThriftServer The generated ostrich-based ThriftServer class that scrooge generates is deprecated and going away soon.  Short-term, you can use scrooge-ostrich's OstrichThriftServer for the same functionality, although longer terms, all projects should be switching to twitter-server.  This review removes the use of the generated ThriftServer for all projects in the birdcage that are using the current version of scrooge.  Some projects unnecessarily include the "--ostrich" in their pom, and those resulted in trivial pom changes.  For projects actually using the generated ThriftServer, I've switched you over to the non-generated OstrichThriftServer.

I have not touched projects that are still using an older version of scrooge, that will be left an exercise for the project owners when they eventually switch to a current version of scrooge.

RB_ID=172503
TBR=true
[split] scrooge: removed ostrich generation.

RB_ID=174926
[split] scrooge-ostrich: add thriftProtocolFactory as val The generated ThriftServer class has a thriftProtocolFactory field that some subclasses use.  Adding this val makes the transition to OstrichThriftServer easier.

RB_ID=175297
[split] properly qualify service parents

RB_ID=175043
[split] scrooge-runtime => scrooge-core

RB_ID=174528
TBR=true
[split] bump util to 6.4.1-SNAPSHOT

RB_ID=178076
TBR=true
[split] We think that mustache actually handles the escaping so that this additional escaping is not needed.

RB_ID=179032