Merging CISLAM Experimental model (no Test Suite available) in JGrassTools

The wrapper of the main module is working correctly. All Oms sub-modules are fine. Wrappers for sub-modules might not be fully functional. 
There is no performance target here.
Honestly I was just trying to port the R code without introducing subltle
typos and errors I would have found very hard to spot.
When the tests passed I did not dare to touch these formulas and give them
a presentable look. I was satisfied by the accomplished (middling) quality
level.

On 3 November 2014 04:05, Andrea Antonello <notifications@github.com> wrote:

> In
> hortonmachine/src/main/java/org/jgrasstools/hortonmachine/modules/hydrogeomorphology/cislam/utils/MapCalculationFunctions.java:
>
> > +                            ((elev-inPitIter.getSampleDouble(c+1, r-1, 0))/(diag)),
> > +                            ((elev-inPitIter.getSampleDouble(c, r-1, 0))/dy),
> > +                            ((elev-inPitIter.getSampleDouble(c-1, r-1, 0))/(diag)),
> > +                            ((elev-inPitIter.getSampleDouble(c-1, r, 0))/dx),
> > +                            ((elev-inPitIter.getSampleDouble(c-1, r+1, 0))/(diag)),
> > +                            ((elev-inPitIter.getSampleDouble(c, r+1, 0))/dy),
> > +                            ((elev-inPitIter.getSampleDouble(c+1, r+1, 0))/(diag))
> > +                            })
> > +                            ))*
> > +                            inKsatIter.getSampleDouble(c, r, 0)
> > +                            );
> > +
> > +                    cumRATIO_WR.setSample(c, r, 0, borderRATIO);
> > +                }
> > +                else if (ratio == 0 && Double.isNaN(elev)){
> > +                    cumRATIO_WR.setSample(c, r
>
> I see you do this a lot. Are you doing this because of performance
> reasons? If I am not mistaken, this doesn't make any difference. And
> readability is way better when you have the var locally defined in the loop.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/moovida/jgrasstools/pull/8/files#r19717923>.
>