> According to the JBoss modules developer guide we should only ever attempt to use the threadContextClassLoader to access resources from the deployment classloader, and I specifically need to lookup user provided files here.

Sure. Still imo the thread context classloader is still semantically something else than a user class loader. The latter is provided by the user (I am thinking OSGi here for example).

> I.E. they are the same thing indeed.

Right, in our case they are, but they don't have to be. It just happens to be that Widlfly uses the thread context class loader to make the deployment class loader available. Anyways, that's probably just hair-splitting here. Just wanted to make clear where I am coming from.

> Do you need me to rename it?

No need. Just doing a build to verify things and then I am going to merge it. What's about master?