1. Won't vector be destructed anyway?  ------- I don't know, but this won't
hurt.
2. Perhaps use initialisation list.            ------- not sure what you
are saying???
3. Tragectory spelling error                    ------- Yep, fixed, then
remvoed code altogether
4. non-functional code                           ------- I knew the code
would be non-functional, so I made it anonymous. Perhaps best to remove.
Now gone
5. Filter fails, chain broken?                   ------- No, uninitialized
filter does not change trajectory, so does nothing.

All pushed onto github again.


On Fri, May 30, 2014 at 9:45 AM, G.A. vd. Hoorn <notifications@github.com>
wrote:

> In industrial_trajectory_filters/src/smoothing_trajectory_filter.cpp:
>
> > +      for(int i=0; i<num_coef_; i++) {
> > +	coef_.push_back(coef[i]);
> > +	sum += coef[i];
> > +      }
> > +      gain_ = sum;		// set gain to be the sum of the coefficients because we need unity gain
> > +      return(true);
> > +    }
> > +    else{
> > +      initialized_ = false;
> > +      return(false);
> > +    }
> > +  }
> > +
> > +  SmoothingTrajectoryFilter::~SmoothingTrajectoryFilter()
> > +  {
> > +    coef_.clear();
>
> Won't the vector be destructed anyway? :)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ros-industrial/industrial_core/pull/77/files#r13231838>
> .
>