update to generic