Some improvements and changes

mainly added some javadoc and tests for the DAO classes
yeah, so commenting the stuff in, in my branch, passes for you,?

hehe, that us weird.

tty next week :lipstick:

On Friday, October 24, 2014, Bruno Oliveira <notifications@github.com>
wrote:

> In
> model/jpa/src/test/java/org/jboss/aerogear/unifiedpush/jpa/PushMessageInformationDaoTest.java:
>
> >
> >          assertThat(variantIDsWithWarnings).hasSize(2);
> >          assertThat(variantIDsWithWarnings).contains("231543432432", "23154343243333");
> > +
> > +//        // warnings for specific user
> > +//        final List<String> variantIDsWithWarningsForUser = pushMessageInformationDao.findVariantIDsWithWarnings(loginName);
> > +//
> > +//        assertThat(variantIDsWithWarnings).hasSize(1); /// this fails... because it contains 2 ?
>
> @matzew <https://github.com/matzew> are you running with mvn clean install?
> This is super weird, I don't have the same problem here
>
>
> <https://cloud.githubusercontent.com/assets/21758/4768881/58efd6ba-5b71-11e4-9c69-6b7dd04b0dfe.png>
>
> Let's discuss it next week.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/abstractj/aerogear-unifiedpush-server/pull/9/files#r19334179>
> .
>


-- 
Sent from Gmail Mobile