Yeah, I was pondering that.  I'll play with it some more today.


On Fri, Feb 14, 2014 at 9:53 AM, Gina Trapani <notifications@github.com>wrote:

> In tests/TestOfTestController.php:
>
> > @@ -187,4 +187,29 @@ public function testExceptionHandling() {
> >          $this->assertEqual('Exception', $v_mgr->getTemplateDataItem('error_type'));
> >          unset($_GET['text']);
> >      }
> > +
> > +    /**
> > +     * Test that a session is started when the controller has run
> > +     */
> > +    public function testSessionStarted() {
> > +
> > +        // Fails in travis.  Hmm.
> > +        //if (session_id() != '') {
> > +            //session_destroy(); // Make sure there's not session from previous tests.
> > +        //}
> > +        //$this->assertEqual('', session_id());
> > +        //$controller = new TestController(true);
>
> Is there a way to rewrite this test with the new session handling without
> using session_id, etc? We just want to assert the session doesn't get
> started when true is sent to the constructor and vice versa.
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/ginatrapani/ThinkUp/pull/1818/files#r9750208>
> .
>