Don't return from a finally block

The code in the finally block always executes, even if an exception is
raised. If a return is done, that will cause exceptions to be silently
ignored.

Some unit tests have been failing because of API changes to the
nova.compute.manager:ComputeManager._delete_instance method but the
use of finally/return ended up silently ignoring that error and
caused the test to appear as if it was passing. Another unit test
fails because of a missing uuid attribute.

It could also potentially cause other exceptions to be ignored at
runtime (such as SystemExit) which is likely not the intended
behavior.

Change-Id: I083ee7215296e35a0027be5b3ddf8b764f44cc5b
Closes-bug: 1324277
Bump hacking to 0.9.x series

Hacking 0.9.0 had a minor bug so require 0.9.1 or higher.

In order to keep this patch to just a requirements bump, ignore new and
stricter hacking rules that are being triggered. Fixing up the code and
turning these on is out of scope of this patch and is for future patches.

Change-Id: Iafbd4adae8c6b446d53b62dfc490eab8e76a43ac
Fix H401,H402 violations and re-enable gating

H401 and H402 got stricter in hacking 0.9, so fix new violations and
re-enable gating.

Change-Id: I4785d14edee1ffdf32e2900f6e6234cbecab6d8a
xenapi: move find_vbd_by_number into volume utils

Above function is only used in volumeops, so moved to volume_utils.
Also added some unit tests to cover that function.

Change-Id: I1298dd35d8a41832475c6d6bd908af8f6576be82
Enabled swap disk to be resized when resizing instance.

When you resize an instance, it is powered off and the root and
ephemeral disks are resized (not swap). Swap is not resized
because it is a partition. To allow the swap disk to be resized,
we have to delete it and re-create it with the correct size.
We do not care about the contents of the swap disk because
when an instance is shut down, the contents of the swap space
are just garbage, the OS doesn't bother about what is in it.

Change-Id: I2bb05f01af6c97e6860dcd79a68884101a13c7d4
Closes-Bug: #1244222
Block device API missing translations for exceptions

Added translations to exceptions raised in the API.

Change-Id: I7b8ba03b735297fee04011c90fc3c6e6f9e27a0e
Fixes typo error in Nova

This submission is to fix the typo error
in "nova/network/linux_net.py" file.

Change-Id: I7219503085eb17a8517ab12c3d9703007f2bc54e
Merge "Don't return from a finally block"
Merge "Block device API missing translations for exceptions"
Merge "Fixes typo error in Nova"
Merge "xenapi: move find_vbd_by_number into volume utils"
Merge "Enabled swap disk to be resized when resizing instance."
Merge "Bump hacking to 0.9.x series"
Merge "Fix H401,H402 violations and re-enable gating"