@George

Yes, these will definitely need to be refactored. 

I just realized that these could also make the categories implementation a lot smoother! Extensions wouldn't have to reference com_categories directly any more! Instead they would use a task like addCategory.subject





Sincerely,
Mathew Lenning

Babel-university.com

P.S. This message was sent via iPhone, so please forgive any errors

> On Apr 28, 2014, at 2:56 AM, George Wilson <notifications@github.com> wrote:
> 
> In libraries/cms/controller/create/base.php:
> 
> > + * @license     GNU General Public License version 2 or later; see LICENSE.txt
> > + */
> > +
> > +defined('JPATH_PLATFORM') or die;
> > +
> > +abstract class JControllerCreateBase extends JControllerJoomlaSave
> > +{
> > +	public function execute()
> > +	{
> > +		//Check for request forgeries
> > +		$this->validateSession();
> > +
> > +		$config = $this->config;
> > +		$url = 'index.php?option='.$config['option'].'&task=add.'.$config['subject'];
> > +
> > +		$prefix = $this->getPrefix();
> I think it would be worth putting this into the getModel - something along the lines of $prefix = $prefix ? $prefix : $this->getPrefix() because you're using it in pretty much every method just for this step
> 
> \
> Reply to this email directly or view it on GitHub.