Fix bug causing empty chef_export tarball

Due to shell expansion not being in effect when calling system with
array of arguments, the tarball w/ chef export ended up empty.

Pass a list of files to be archived as individual arguments instead
of a glob.
Do not move the exported file if tar fails
Remove revision from RoleObject, duplicates crowbar_revision
Rename revision -> crowbar_revision, fix call to role & sync check
Refactor incrementing crowbar revision to a separate method
Use crowbar_revision helper
Refactor increment_crowbar_revision and crowbar_revision in NodeObject
Merge pull request #1060 from bkutil/fix_export

Fix export
Fix i18n strings moved in #1059
Merge pull request #1067 from bkutil/fix_missing_translation

Fix i18n strings moved in #1059
Merge pull request #1065 from bkutil/proposal_revision_increments

Refactor revision increments
Mark proposals as applied on commit

This is another attempt for a fix of
https://bugzilla.novell.com/show_bug.cgi?id=861309

The previous solution was based on comparing the crowbar-revision of
proposal and the corresponding role. However, these numbers can diverge
arbitrarily and the comparison would not work as expected, as was observed in
https://bugzilla.novell.com/show_bug.cgi?id=877486

This patch uses a dedicated 'committed' attribute, which defaults to
false. It is set to 'true' after a proposal is committed and re-set back
to 'false' on any other operation.
Run brakeman automatically in travis

As we're already including brakeman in our gem bundle, it'd be nice
to actually run it automatically.

When we're green w/ the vulnerabilities, we can turn on the -z option
and let the build fail on new ones.
Merge pull request #1071 from bkutil/add_brakeman_to_travis

Run brakeman automatically in travis
Set chef reconnect rate to 3

I have put the chef retry connection rate down to 3 retries in order to
prevent extreme long page loadings in case of the chef server is gone. I
think it should be enough to retry to connect only 3 times.
Selecting raw mode w/o loosing data (bnc#882976)

The ticket https://bugzilla.novell.com/show_bug.cgi?id=882976 explains
that we loose data if we switch from the custom proposal form into raw
proposal form.

To prevent loosing data i have integrated a confirmation dialog that
have to be accepted before we can switch to another page if we have
changed something on the current proposal form.

This solution is a shortterm solution until we get a better javascript
library with dynamic data binding to switch between raw and custom view
without a page reload and without loosing data.
Set the applied flag in proposal_commit

Instead of setting it in the controller, check for the return value of
apply_role in the proposal_commit ensure block, and mark the proposal as
applied accordingly.
Switch rspec format to nested
Merge pull request #1076 from bkutil/use_nested_format_in_rspec

Switch rspec format to nested
Fix UI if chef-server is gone (bnc#865072)

The ticket https://bugzilla.novell.com/show_bug.cgi?id=865072 explains
that crowbar behaves bad if the chef-server is gone and not reachable.

In order to display a better usable error page i have integrated more
exception classes that gets catched by the application controller to
display a proper error page if there are documents not found or the chef
server is gone.