Removed checks and assertions upon form_Map.
Add a space after node ID (upon --gen-ids).
Merge pull request #987 from vasslitvinov/restore-space-in-generated-C-code

Add a space after node ID (upon --gen-ids).

There is often a space missing after the node ID in the generated code, e.g.:

  /* 889339*/ ret = type_tmp;

This space disappeared due to 23311c03 aka r20461, which commit
was unrelated:

+      info->cStatements.push_back("/* " + numToString(stmt->id) + "*/ ");
-    fprintf(outfile, "/* %7d */ ", stmt->id);

I am restoring this space for convenience highlighting in emacs
and for consistency.

Reviewed by Mike.
Merge pull request #986 from vasslitvinov/remove-checks-and-asserts-upon-form_Map

Removed checks and assertions used with form_Map().

The files createTaskFunctions.cpp and implementForallIntents.cpp
contained these idioms:

  form_Map(SymbolMapElem, e, ...) {
    INT_ASSERT(e->key);
    ...

and/or

  form_Map(SymbolMapElem, e, ...) {
    if (Symbol* sym = e->key) {
      ...

Since the 'form_Map' macro only yields non-NULL things by design,
the above assert and check are not needed. I am removing them.

I also replaced:      vars->put(sym, arg);
with the equivalent:  e->value = arg;
for efficiency.


These changes can also be applied to flattenFunctions.cpp.
I did not do so, to keep that code undisturbed.

Reviewed by Mike.
Fixed .bad mismatch for hplx.chpl.
Merge pull request #991 from vasslitvinov/fix--hplx.bad--mismatch

Fixed .bad mismatch for hplx.chpl.

This test has been failing in more and more diverse ways.
I keep relaxing PREDIFF to accept these failures, so I can have .bad
and match clean against it.

Or, Kyle suggests, maybe this test shouldn't have a .bad?