Support added for exceptions with ASYNCIFY

The general scheme is not very complicated. Changes:

1. Rather than doing `dynCall_vi` on the *foo*__asnc_cb function, we use `invoke_vi`. This is essential if the callback functions are to throw exceptions.
1. If a callback did throw an exception, then we should reenter the parent callback function only if it checks for exceptions at the resume point. Otherwise, the exception should propagate up. We check for this using an extra boolean in the async context: `emscripten_alloc_async_context` now has an extra argument which the C++ code uses to indicate whether the async function is called with "invoke" or "call". (So the `invoke` argument to `emscripten_alloc_async_context` is set when `__THREW__` is checked immediately after the async call. We also update the invoke flag in `emscripten_realloc_context`.)
1. If the exception isn't caught anywhere, we rethrow it finally so that an error message is provided (admittedly not a very clear one, but it's no worse than when an exception is throw out of a synchronous `main`).

This pull request works in conjunction with the pull request to the fastcomp compiler.
Oh sorry, I thought you meant malloc, and yes there is a bug with alloca.
Could you file a new issue for it?
On Sep 10, 2014 12:44 AM, "Nicholas Wilson" <notifications@github.com>
wrote:

> In src/library_async.js:
>
> > -        ___async_unwind = 1;
> > -        continue;
> > +      if (!___async_cur_frame) {
> > +        // print ugly integer in console, same as if an exception is thrown out of main()
> > +        if (activeException) _emscripten_async_abort_with_exception();
> > +        return;
> > +      }
> > +      catchesExceptions = {{{ makeGetValueAsm('___async_cur_frame', 8, 'i8') }}};
> > +      // When an async function throws an exception, it can't just bubble up as
> > +      // normal (because there isn't a native JavaScript call stack, we're
> > +      // manually reconstructing it here).  We keep rewinding the stack until we
> > +      // find a function that can handle the exception.
> > +      if (!!catchesExceptions | !activeException) {
> > +        __THREW__ = activeException|0;
> > +        invoke_vi({{{ makeGetValueAsm('___async_cur_frame', 12, 'i32') }}},
> > +                  (___async_cur_frame + 12)|0);
>
> Fair enough! I didn't realise LLVM had a dedicated instruction for
> __builtin_alloca to use. Either way -- I ran the snippet of test code above
> before committing the change; the assertion *does* fire when a callback
> places something on the stack above the async_ctx, then tries to expand the
> async_ctx.
>
> Maybe we should just make the async_ctx structures on the heap in the
> first place? Or if that hurts performance, we could move them to the heap
> in the uncommon case that realloc_async_context needs to expand it but
> can't.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/kripken/emscripten/pull/2772/files#r17312816>.
>