Done.


On Tue, Apr 1, 2014 at 10:26 AM, Yuji Nakayama <notifications@github.com>wrote:

> In lib/linter/clang.coffee:
>
> > +      return callback(error) if error?
> > +
> > +      if result.exitCode == 0 || result.exitCode == 1
> > +
> > +        pattern = ///
> > +          ^(.+):(\d+):(\d+):\s*  # file / line / col
> > +          ([\s|[a-zA-Z]*):\s*
> > +          ([^]+)
> > +        ///
> > +
> > +        violations = []
> > +        items = result.stderr.split '\n'
> > +        for item in items[...-1]
> > +          matches = item.match(pattern)
> > +          continue unless matches
> > +          [file, line, col, severity, msg] = matches
>
> This needs to be [_, file, line, col, severity, msg] since you removed
> the [1..5] above.
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/yujinakayama/atom-lint/pull/40/files#r11165249>
> .
>