moves declaration of expected_config in spec
return {} instead of nil for empty config_hash
moves no violations conditional into model method
fixes double quotes
rewords PullRequest::SUCCESS_MESSAGE
rename SuccessMessage to SuccessNotification