Various improvements to the JSON code and test reporting bits

Good feedback - I'll clean this up and rebase today.—
Sent from Mailbox

On Thu, Aug 28, 2014 at 12:48 PM, Josh Suereth <notifications@github.com>
wrote:

>> -
>> -  implicit val executionAnalysisFormat = new Format[ExecutionAnalysis] {
>> -    override def writes(analysis: ExecutionAnalysis): JsValue = {
>> -      val (discriminator, rest) =
>> -        analysis match {
>> -          case c: ExecutionAnalysisCommand => "command" -> Json.toJson(c)
>> -          case k: ExecutionAnalysisKey => "key" -> Json.toJson(k)
>> -          case e: ExecutionAnalysisError => "error" -> Json.toJson(e)
>> -        }
>> -      val baseObj = rest match {
>> -        case o: JsObject => o
>> -        case other => throw new RuntimeException(s"Serialized $analysis as a non-object $other")
>> +  private val positionReads: Reads[xsbti.Position] = (
>> +    (__ \ "lineContent").read[String] and
>> +    (__ \ "line").readNullable[Int] and
>> +    (__ \ 'offset).readNullable[Int] and
> +1.  Symbols in Scala, IMHO, don't add a ton of value.
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/sbt/sbt-remote-control/pull/187/files#r16855847