Yeah, let's


Win~


On Fri, Jan 17, 2014 at 4:29 PM, Steven <notifications@github.com> wrote:

> In thumbnails/post_processors.py:
>
> > +    # Construct command to optimize image based on filetype
> > +    command = None
> > +    if filetype == "jpg" or filetype == "jpeg":
> > +        command = jpg_optimize_command
> > +    elif filetype == "png":
> > +        command = png_optimize_command
> > +    elif filetype == "gif":
> > +        command = gif_optimize_command
> > +
> > +    # Run Command
> > +    if command:
> > +        command = command % {'filename': thumbnail_filename}
> > +        try:
> > +            status_code = call(command, shell=True, stdout=PIPE)
> > +        except OSError:
> > +            raise ValueError('Cannot optimize image with parameters %s', command)
>
> So that means if we are to raise OSError, we should get rid of the try
> except block altogether?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/ui/django-thumbnails/pull/38/files#r8960514>
> .
>