Can you say a bit more, Im not sure I know which you are referring to.

Anticipating what you might mean: - inet_ntop() returned FALSE if the IP isn't valid, which meant it rolled validation and conversion into one function, which was efficient. When I avoided inet_ntop(), I had to look again at validation. I noticed that ip2long() does validate its argument, but this wasn't available in ip_compare() because it wasn't detected or trapped in ip2long32() or ip2ulong(). Which meant those 2 functions could have validation errors in some cases too.  So the updated PR has these two functions aware of the possibility that ip2long() may return FALSE or zero, and ensures these aren't confused.

In other words, ip_compare() only uses ip2ulong (like the original code), but ip2ulong() uses ip2long32() internally so both are fixed.  

If that's not an answer to your question can you clarify which lines contain the same test done 2 different ways?, so I can answer what you asked :)