Yea, we should probs pull in underscore to handle that anywho. but no
worries === undefined works


On Fri, May 30, 2014 at 10:08 AM, Nick Gartmann <notifications@github.com>
wrote:

> In covalence.js:
>
> >  	login: function(args) {
> >  		var username = args['username'],
> >  		    password = args['password'];
> >
> > +		if(username === undefined) {
>
> Looks like it returns true if the thing isn't typeof string, which is
> correct if its undefined. But if its an object or number or something I'd
> prefer the thing to crash with a proper error message than to prompt the
> user for their email & password.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/RokkinCat/covalence-cli/pull/14/files#r13233002>.
>