> Can you reproduce this with a test? Is this particular to a specific version of rails?

Yes, i will


On Feb 18, 2014, at 5:47, Phill Baker <notifications@github.com> wrote:

> In lib/vanity/adapters/active_record_adapter.rb:
> 
> > @@ -79,7 +79,7 @@ def self.retrieve(experiment, identity, create = true, update_with = nil)
> >            if record = VanityParticipant.first(:conditions=>{ :experiment_id=>experiment.to_s, :identity=>identity.to_s })
> >              record.update_attributes(update_with) if update_with
> >            elsif create
> > -            record = VanityParticipant.create({ :experiment_id=>experiment.to_s, :identity=>identity }.merge(update_with || {}))
> > +            record = VanityParticipant.create({ :experiment_id=>experiment.to_s, :identity=>identity.to_s }.merge(update_with || {}))
> So I can see doing this for code consistency, but I believe the underlying column type of string will result in active record casting this to a string. Can you reproduce this with a test? Is this particular to a specific version of rails?
> 
> —
> Reply to this email directly or view it on GitHub.
>