Thanks a lot i will review this the weekend!
Am 07.03.2014 19:39 schrieb "David Buchmann" <notifications@github.com>:

> In Block/MenuBlockService.php:
>
> > +    {
> > +        throw new \RuntimeException('Not used at the moment, validation for editing using a frontend or backend UI could be changed here');
> > +    }
> > +
> > +    /**
> > +     * {@inheritdoc}
> > +     */
> > +    public function execute(BlockContextInterface $blockContext, Response $response = null)
> > +    {
> > +        if (!$response) {
> > +            $response = new Response();
> > +        }
> > +        $menu = $blockContext->getBlock()->getMenuNode();
> > +
> > +        // if the reference target menu does not exist, we just skip the rendering
> > +        if ($blockContext->getBlock()->getEnabled() && null !== $menu) {
>
> i propose to reorder this a bit. (i know the other services are not a very
> good example atm)
>
> $block = $blockContext->getBlock();if (!$block->getEnabled() || null === $block->getMenuNode()) {
>     return $response ? : new Response();}
> return $this->renderResponse...
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/symfony-cmf/BlockBundle/pull/170/files#r10393938>
> .
>