values generator  added #12