Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56334
Reviewing r1587887:
s/ attrs.getValue(i) / attributeValue / in the messages as well,
so that the actual expression text that is processed is printed in the message.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1590604 13f79535-47bb-0310-9956-ffa450edef68
Increase length of text written so expected exception is triggered on client disconnect with NIO2.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1590635 13f79535-47bb-0310-9956-ffa450edef68
Need even larger writes to keep test happy on Windows VM

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1590638 13f79535-47bb-0310-9956-ffa450edef68
Fix Javadoc warnings

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1590646 13f79535-47bb-0310-9956-ffa450edef68
Drop useless null checks.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1590647 13f79535-47bb-0310-9956-ffa450edef68
Clarify

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1590648 13f79535-47bb-0310-9956-ffa450edef68
Document JspAttribute.isDynamic() and correct wrong value of this flag for "omit" attribute of <jsp:attribute> action.

I think there were no observable consequences of this typo. The "dynamic" flag makes sense only for attributes of a CustomTag.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1590801 13f79535-47bb-0310-9956-ffa450edef68
Correct the handling of back-slash escaping in the EL parser and no longer require that "\$" or "\#" must be followed by "{" in order for the back-slash escaping to take effect.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1590835 13f79535-47bb-0310-9956-ffa450edef68
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56334
Additional tests and fixes
Includes the following:

1. Allow '\' in xmlns attributes of UninterpretedTag. A test added.

(Java escaping was missing. Xml-escaping is still missing. I think it is unlikely that anybody would use such values for xmlns attributes)

2. Fix interaction between Validator.ValidateVisitor.checkXmlAttributes(CustomTag ..) and getJspAttribute().

- EL expression was parsed twice in both methods. Now I am passing the already parsed EL.
- getJspAttribute() has EL validation code, so reduce duplication
- When calling getJspAttribute() you have to pass original attrs.getValue(i), not the textual value.

3. Fix Validator.ValidateVisitor.XmlEscapeNonELVisitor
- It was not EL-escaping its text. Tests added.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1590842 13f79535-47bb-0310-9956-ffa450edef68
Correct unit tests now EL Parser has been fixed to correctly parse "\$" as "$".

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1590911 13f79535-47bb-0310-9956-ffa450edef68