fix quiz build_assignment for rails 3

setting self.assignment_id to nil also resets
self.assignment in rails 3 (but not in rails 2)

Change-Id: I679c0ebb8a26a6a4cb5ce5a69b688f094c75143d
Reviewed-on: https://gerrit.instructure.com/29646
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: James Williams  <jamesw@instructure.com>
QA-Review: James Williams  <jamesw@instructure.com>
set max_attempts on SummaryMessageConsolidator job

if it fails, the periodic job will reschedule soon anyway, and we don't
want one bad shard backing everything up

Change-Id: I49bd2a9b0f3cd399deb2424e0382f8d54fd483ce
Reviewed-on: https://gerrit.instructure.com/31148
Reviewed-by: Rob Orton <rob@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
fix wiki links in course copy/migrations

test plan:
 - with draft state enabled
 * create a wiki page
   - use the sidebar to add a link to another wiki page
 * save the page
 * edit the page
   - html view should show the href as ../pages/.. not ../wiki/..
   - copy the link, changing the href to be ../wiki/..
 * save the page
 * copy the course
 * navigate to the copied wiki page
   - both links should point to the page in the new course

fixes CNVS-11443

Change-Id: Ib7f8b175ac6d894a9bfa651f8536b7cd48b60aac
Reviewed-on: https://gerrit.instructure.com/30780
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Matt Fairbourn <mfairbourn@instructure.com>
temporarily raise default_per_page on list courses

this endpoint was originally non-paginated. it was appropriate to make
it paginated (it was documented as paginated, and we cannot leave it
unpaginated), but we should have communicated and given a grace period
for endpoint consumers to prepare first.

temporarily raise the default per_page while they catch up.

fixes CNVS-11574

Change-Id: I853dadd9a093dac555d3a240aa64d275d040b29b
Reviewed-on: https://gerrit.instructure.com/31209
Reviewed-by: Simon Williams <simon@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Miles Wright <mwright@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
fix discussion_topic importing into groups

test plan:
* create a course with a discussion topic
* export the course
* create a new course
* add a user group in the new course
* import the package into the course
* should not fail or import as a group topic

fixes #CNVS-11377

Change-Id: Ied4c80ed48d6495bdee60f79948445141997d5e8
Reviewed-on: https://gerrit.instructure.com/31087
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Matt Fairbourn <mfairbourn@instructure.com>
remove old code in user model

Change-Id: Iebd2bda316925c4a3a6210abe636cbc4101b525d
Reviewed-on: https://gerrit.instructure.com/31126
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: Landon Wilkins <lwilkins@instructure.com>
QA-Review: Landon Wilkins <lwilkins@instructure.com>
Accessibility: Moved the right sidebar to after the main content in the DOM

Fixes CNVS-6699

Test Plan:
- Click through a few pages with and without a breadcrumb nav

Change-Id: Ib1c1e03ce6b63623b0e3ba778ac78ce4bd1b60cf
Reviewed-on: https://gerrit.instructure.com/28534
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
Reviewed-by: Ryan Florence <ryanf@instructure.com>
Product-Review: Ryan Florence <ryanf@instructure.com>
frd fix student_reports_spec for rails 3

Change-Id: I480f8e6a31ee36a78c67dcea653d778accf4d921
Reviewed-on: https://gerrit.instructure.com/31140
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: James Williams  <jamesw@instructure.com>
QA-Review: James Williams  <jamesw@instructure.com>
don't fail migration if account isn't found

it'll just mark the attachment as broken

Change-Id: Ifefb66178d905505b2658b695f148c4f6895c7f6
Reviewed-on: https://gerrit.instructure.com/31170
Reviewed-by: Rob Orton <rob@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
conversations: always give copies of messages to authors

fixes CNVS-11517

test plan:
  * create a conversation with a course context in new conversations
  * reply to the conversation by email
  * verify that the new message is visible both to the email author
      and the author of the previous message

Change-Id: I78496d31fb82b773007c22d4478d62061cb9efef
Reviewed-on: https://gerrit.instructure.com/31101
Reviewed-by: Jon Willesen <jonw@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Product-Review: Braden Anderson <banderson@instructure.com>
don't copy all the grading standards in every course copy

test plan:
 - set a grading standard for a course
 - link a new grading standard to an assignment in the course
 - also have an assignment without a grading standard
 - and a grading standard that's unused
 - copy the course (without selecting content)
   - the copy should have all the grading standards from the original
 - copy the course, selecting only the assignment with no grading standard
   - the copy should have no grading standards
 - copy the course, selecting only the assignment with the grading standard
   - only the assignment's grading standard should be in the new course
 - copy the course, selecting only course settings
   - only the course's grading standard should be in the new course

fixes CNVS-5499

Change-Id: I3899769e960b17869245ebf9a5a8c4811755c362
Reviewed-on: https://gerrit.instructure.com/30775
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Matt Fairbourn <mfairbourn@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
Reviewed-by: Bracken Mosbacker <bracken@instructure.com>
Product-Review: Bracken Mosbacker <bracken@instructure.com>
no longer uses regru-premailer

fixes CNVS-11460

test plan
regression tests on these notification messages:
- new announcement (text email and summary)
- new discussion topic (text email and summary)
- new discussion entry (text email and summary)
- summaries (text and html emails
- updated wiki page (text email, html email, and summary)

regression test on calendar event desrciption in ics

regression test on aria-labels for multiple choice quiz answer
inputs. radio and checkboxes

Change-Id: I229837357a8e1bc1bb887a1b047f86636a62209a
Reviewed-on: https://gerrit.instructure.com/31045
Reviewed-by: Braden Anderson <banderson@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Trevor deHaan <tdehaan@instructure.com>
Product-Review: Joel Hough <joel@instructure.com>
fix module item footer for quizzes

fixes CNVS-11540

when a url was built with the model name it replaced the namespace model
string of "quizzes/quiz" with "quizzes:quiz" so that the slash wouldn't mess
up the url. We need to translate this back before attempting to classify
the quiz string back to the class name.

test plan:
- add a quiz to a module with something before and after it in the module
- navigate to the quiz from the module
- the footer with prev/next links should appear

Change-Id: I559b646fb799f48c6782dc554eb26dca7f6b348b
Reviewed-on: https://gerrit.instructure.com/31215
QA-Review: Myller de Araujo <myller@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Josh Simpson <jsimpson@instructure.com>
Product-Review: Derek DeVries <ddevries@instructure.com>
srgb - adds submission type info

fixes CNVS-11236

test plan
=========
* in screenreader gradebook
* select an assignment
* verify that submission type is correct
* check multiple assignment types :)

Change-Id: I4fc24aecb048bf1518ae00c1ddd6149e12a38873
Reviewed-on: https://gerrit.instructure.com/30263
Reviewed-by: Cameron Sutter <csutter@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Product-Review: Liz Abinante <labinante@instructure.com>
remove prerequisites_satisfied? recursive parameter

test plan:
 * simple regression on student module progression

closes CNVS-11482

Change-Id: I901bf58e6d28b94b6358969184557c99b8c53a53
Reviewed-on: https://gerrit.instructure.com/30905
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Matt Fairbourn <mfairbourn@instructure.com>
refactor progression deep_evaluate

test plan:
 * simple regression on student module progression

closes CNVS-11483

Change-Id: I58cfd4f71d8fb2fe597f9f0d72523e07cc04de75
Reviewed-on: https://gerrit.instructure.com/30906
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Matt Fairbourn <mfairbourn@instructure.com>
move evaluate_for into the progression object

Change-Id: I94f6a66348827b7138ca0e5e1d45008b17f79894
Reviewed-on: https://gerrit.instructure.com/30981
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Matt Fairbourn <mfairbourn@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
refactor evaluate/deep_evaluate logic

test plan:
 * full regression of all module progression functionality

closes CNVS-11505

Change-Id: I63f542d5d42f950cf9c8117e12ecce4518e2ccf4
Reviewed-on: https://gerrit.instructure.com/30983
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Matt Fairbourn <mfairbourn@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
keep unpublished module completion requirements

completely refactored the way completion requirements are vetted

test plan:
 * regress module progression

fixes CNVS-11507

Change-Id: Ie56b7c189f3b38be2410c2496c06cf143641e3b2
Reviewed-on: https://gerrit.instructure.com/31056
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Matt Fairbourn <mfairbourn@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
fix assignment_override_student for rails 3

Change-Id: I4362e421bbc2a23c5afdadcc5658abe17e8a1402
Reviewed-on: https://gerrit.instructure.com/28693
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: James Williams  <jamesw@instructure.com>
QA-Review: James Williams  <jamesw@instructure.com>