updated for params