I haven't seen any discussion about this on
dev@brooklyn.incubator.apache.org - did you send the email you mentioned?


On 15 May 2014 16:04, Andrew Kennedy <notifications@github.com> wrote:

> In
> software/nosql/src/main/java/brooklyn/entity/nosql/couchbase/CouchbaseLoadGenerator.java:
>
> > +            @EffectorParam(name = "password", description = "password used for authentication to the cluster") String password,
> > +            @EffectorParam(name = "iterations", defaultValue = "1000",
> > +                description = "number of iterations to run") Integer iterations,
> > +            @EffectorParam(name = "num-items", defaultValue = "1000",
> > +                description = "number of items to operate on") Integer numItems,
> > +            @EffectorParam(name = "keyPrefix", description = "prefix for keys") String keyPrefix,
> > +            @EffectorParam(name = "num-threads", defaultValue = "1",
> > +                description = "number of threads to use") Integer numThreads,
> > +            @EffectorParam(name = "num-instances", defaultValue = "1",
> > +                description = "number of connection instances to put into the shared connection pool") Integer numInstances,
> > +            @EffectorParam(name = "random-seed", defaultValue = "0", description = "random seed") Integer randomSeed,
> > +            @EffectorParam(name = "ratio", defaultValue = "33",
> > +                description = "Specify SET/GET command ratio (default: 33, i.e. 33% SETs and 67% GETs)") Integer ratio,
> > +            @EffectorParam(name = "min-size", defaultValue = "50",
> > +                description = "minimum size of payload, i.e. document body") Integer minSize,
> > +            @EffectorParam(name = "max-size", defaultValue = "5120",
>
> See dev@brooklyn.incubator.apache.org or
> https://gist.github.com/grkvlt/96bcd7a057c9f9e4c568 for discussion.
>
> I would still recommend changing these descriptions to sentence case, with
> initial capitals. Are they also copied from the documentation? My ideal
> change would be something like the following, with a parenthetical note
> giving the argument name.
>
> @EffectorParam(name = "minSize", defaultValue = "50",
>         description = "Minimum size of payload, i.e. document body (the min-size argument)") Integer minSize
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/brooklyncentral/brooklyn/pull/1383/files#r12693861>
> .
>



-- 
Martin Harris
Lead Software Engineer
Cloudsoft Corporation Ltd
www.cloudsoftcorp.com
Mobile: +44 (0)7989 047-855