VMware: Remove class orphaned by ESX driver removal

HostState was only used by the ESX driver, which was removed in
change I718fc0ee67dbd625af00c20fa4e34b8a35015437.

Also remove LOG, which is no longer used following previous removals.

Change-Id: I22e30c01e5b5219df858219dc1fda335a83ad225
VMware: Remove VMwareImage.file_size_in_gb

file_size_in_gb was rounding down. This is counter intuitive, as a
512MB disk is reported as 0GB. However, this rounding weirdness was
required for correctness in a way which wasn't obvious. When we test
if an image needs to be resized, we test instance.root_gb >
image.file_size_in_gb. Because file_size_in_gb was rounded down, an
image slightly smaller than 1GB will be reported as 0GB and therefore
resized.

The source of the rounding confusion is the bytes->gb conversion. To
make the code more obviously correct, I have switched it to instead
convert gb->bytes, which does not involve rounding. To ensure this
never trips anybody up, I have removed file_size_in_gb.

Change-Id: I99d20e3b1383e29cddff3d1016c4bcedc1683c4d
Remove websocketproxy workaround

Now that we require websockify >= 0.6 we can remove the workaround code
as pointed out in the TODO.

Change-Id: I05dd6edba00264f22d868b4318ad7a4fb621c996
Cleanup _convert_block_devices

_convert_block_devices was instantiating 2 objects for every 1
returned due to the _is_transformable test. This change simplifies the
code by removing the nested function, and at the same time does the
conversion in a single pass, which is more efficient.

Change-Id: Id6b583a1c08d684fcff073dd0289be8e3919ba0a
libvirt: split firewall tests out into test_firewall.py

The test_driver.py test module had a couple of classes which
were testing functionality from firewall.py. Since test_driver.py
is a really huge file, it is better for the firewall class tests
to live in a separate test_firewall.py module

Related-bug: #1369516
Change-Id: Ibb347780b7b79521ce87b08023771381726b0d53
libvirt: convert HostStateTestCase to avoid DB usage

The HostStateTestCase test case does not do anything DB
related. Convert it to NoDBTestCase to avoid DB setup penalty.
This improves perf from 1.7s to 0.2s

Partial-bug: #1369516
Change-Id: I0b1030b8a4e8c32f24c5b3a08ff86fa5bad06937
Remove the nova-manage flavor sub-command

The nova-manage flavor sub-command was deprecated in Juno milestone-1
via commit a601556684f18059e478ba645aff8276c9c78a4a with a note that it
will be removed in Kilo.

This removes it.

Change I4e2399f2fbab2c20299dd62c104b9220c1d36fb2 is to remove the
related Tempest tests.

Change-Id: I1798c8a0697009b3dcebeb818580c8323880e395
Merge "libvirt: split firewall tests out into test_firewall.py"
Merge "libvirt: convert HostStateTestCase to avoid DB usage"
Merge "Remove websocketproxy workaround"
Merge "Cleanup _convert_block_devices"
Merge "Remove the nova-manage flavor sub-command"
Merge "VMware: Remove VMwareImage.file_size_in_gb"
Merge "VMware: Remove class orphaned by ESX driver removal"