Eng 6245 Add support for applying a binary changelog

Yeah, the half-baked workaround I had in my head for eliminating the angle
brackets was to rename the templated class (some silliness like
SerializeInputGeneric) and make SerializeInput itself a typedef of
SerializeInputGeneric<BIG_ENDIAN>. But that's (as mentioned above) rather
half-baked, and explicit seems better.


On Wed, Jul 2, 2014 at 3:59 PM, aweisberg <notifications@github.com> wrote:

> In src/ee/common/tabletuple.h:
>
> > @@ -314,7 +314,8 @@ class TableTuple {
> >
> >      int compare(const TableTuple &other) const;
> >
> > -    void deserializeFrom(voltdb::SerializeInput &tupleIn, Pool *stringPool);
> > +    void deserializeFrom(voltdb::SerializeInputBE &tupleIn, Pool *stringPool);
> > +    void deserializeFromDR(voltdb::SerializeInputLE &tupleIn, Pool *stringPool);
>
> That was what I start doing, but even with a default template argument you
> have to add angle brackets. At that point I am updating every instance and
> it make sense to be explicit.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/VoltDB/voltdb/pull/1470/files#r14479898>.
>



-- 

*Alex Rogers,* Software Engineer
*VoltDB, Inc.*
*E:* arogers@voltdb.com <tbento@voltdb.com>
www.voltdb.com <http://voltdb.com>
Follow VoltDB on Twitter <https://twitter.com/voltdb>, Facebook
<https://www.facebook.com/VoltDB?sk=wall>, and LinkedIn
<http://www.linkedin.com/company/voltdb>