Delete slop2

Created a pull request . https://github.com/voldemort/voldemort/pull/210
for the delete issue. Thanks once again for pointing it out, I wasn't aware
of that issue.

Thanks,
Arun.


On Fri, Aug 22, 2014 at 11:27 AM, Arunachalam <arunachalam.t@gmail.com>
wrote:

> This is bad, will fix it.
>
>
> On Fri, Aug 22, 2014 at 11:15 AM, vinoth chandar <notifications@github.com
> > wrote:
>
>> In
>> src/java/voldemort/store/routed/action/PerformParallelDeleteRequests.java:
>>
>> > +                                 boolean isParallel) {
>> > +        Node node = response.getNode();
>> > +        Exception ex = null;
>> > +        if(!(response.getValue() instanceof Exception)) {
>> > +            return;
>> > +        }
>> > +
>> > +        ex = (Exception) response.getValue();
>> > +        if(ex instanceof ObsoleteVersionException) {
>> > +            // ignore this completely here this means that a higher version was
>> > +            // able to write on this node and should be termed as clean success.
>> > +            return;
>> > +        }
>> > +
>> > +        if(enableHintedHandoff) {
>> > +            if(ex instanceof UnreachableStoreException || ex instanceof QuotaExceededException) {
>>
>> While you are at it, see
>> https://github.com/voldemort/voldemort/blob/493f500852d2dca30a61026d08d4aa1cf1952777/src/java/voldemort/client/DefaultStoreClient.java#L103
>> We seem to be fetching out the entire blob using a get instead of using
>> getVersions.. ?
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/voldemort/voldemort/pull/209/files#r16612543>.
>>
>
>