added docs for attributes