very good point, i'll fix that up.



On Tue, Mar 4, 2014 at 11:20 AM, Dan Carley <notifications@github.com>wrote:

> In lib/vcloud/core/vm.rb:
>
> > @@ -101,6 +101,7 @@ def configure_guest_customization_section(name, bootstrap_config, extra_disks)
> >          if bootstrap_config.nil? or bootstrap_config[:script_path].nil?
> >            interpolated_preamble = ''
> >          else
> > +          bootstrap_config[:vars] = {} unless bootstrap_config.key?(:vars)
>
> Is it right to modify this hash (passed by reference?) in-place? How about:
>
> preamble_vars = bootstrap_config[:vars] || {}preamble_vars.merge!(:extra_disks => extra_disks)
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/alphagov/vcloud-core/pull/10/files#r10250941>
> .
>