bug #9211 [Form] Fixed memory leak in FormValidator (bschussek)

This PR was merged into the 2.3 branch.

Discussion
----------

[Form] Fixed memory leak in FormValidator

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #9187
| License       | MIT
| Doc PR        | -

Commits
-------

1bb7e4d [Form] Added method Form::getClickedButton() to remove memory leak in FormValidator
5329ab5 [Form] Fixed memory leak in FormValidator
Check if the pipe array is empty before calling stream_select()
bug #9367 [Process] Check if the pipe array is empty before calling stream_select() (jfposton)

This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes #9367).

Discussion
----------

[Process] Check if the pipe array is empty before calling stream_select()

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #9280
| License       | MIT
| Doc PR        |

ProcessPipes generates a warning frequently which can cause issues for custom shutdown functions. Adding a check to see if the pipe array is empty should be functionally equivalent without having to generate the error.

Fixes: #9280

Commits
-------

12f95e2 [Process] Check if the pipe array is empty before calling stream_select()
[AclProvider] Fix incorrect behaviour when partial results returned from cache
Fixed ModelChoiceList tests in Propel1 bridge.
minor #9517 [2.2] Fixed ModelChoiceList tests in Propel1 bridge (jakzal)

This PR was merged into the 2.2 branch.

Discussion
----------

[2.2] Fixed ModelChoiceList tests in Propel1 bridge

Tests on 2.2 are broken since #9469 was merged.

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

1e2d14e Fixed ModelChoiceList tests in Propel1 bridge.
CS fix
if handler_id is identical to null fix
Fix mistake in translation's service definition.
bug #9537 [FrameworkBundle] Fix mistake in translation's service definition. (phpmike)

This PR was submitted for the 2.3 branch but it was merged into the 2.2 branch instead (closes #9537).

Discussion
----------

[FrameworkBundle] Fix mistake in translation's service definition.

Wrong class parameter fixed.

Commits
-------

b542e84 [FrameworkBundle] Fix mistake in translation's service definition.
Removed useless check if self::$trustProxies is set

In Request::getClientIps() on line 772 there is a check if self::$trustedProxies is not set. If this condition evaluates to true the method will return.
Because of this the second identical check on line 783 will never evaluate to true, as when reaching this position self::$trustedProxies must be set.
minor #9526 [HttpFoundation] Removed useless check if self::$trustProxies is set (Danez)

This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #9526).

Discussion
----------

[HttpFoundation] Removed useless check if self::$trustProxies is set

In Request::getClientIps() on line 772 there is a check if self::$trustedProxies is not set. If this condition evaluates to true the method will return.
Because of this, the second identical check on line 783 will never evaluate to true.

Commits
-------

21f2aee [HttpFoundation] Removed useless check if self::$trustProxies is set
minor #9520 CS fix (peterkokot)

This PR was merged into the 2.2 branch.

Discussion
----------

CS fix

Commits
-------

f348731 CS fix
minor #9521 CS fix (peterkokot)

This PR was merged into the 2.2 branch.

Discussion
----------

CS fix

I hope this is not BC break though handler_id checking should be done with identical comparison operator I believe.

Commits
-------

1b6b1e9 if handler_id is identical to null fix
[DependencyInjection] removed the unused Reference and Parameter classes use statements from the compiled container class
[Validator] fix docblock typos
bug #9352 [Intl] make currency bundle merge fallback locales when accessing data, ... (shieldo)

This PR was merged into the 2.3 branch.

Discussion
----------

[Intl] make currency bundle merge fallback locales when accessing data, ...

...allowing use of country-specific locales

Fixes #9262.

Commits
-------

edc287b [Intl] make currency bundle merge fallback locales when accessing data, allowing use of country-specific locales
minor #9555 [Validator] fix docblock typos (shieldo)

This PR was merged into the 2.2 branch.

Discussion
----------

[Validator] fix docblock typos

Commits
-------

8d32c9c [Validator] fix docblock typos
minor #9554 [DependencyInjection] removed the unused Reference and Parameter classes use statements from the compiled container class (hhamon)

This PR was merged into the 2.2 branch.

Discussion
----------

[DependencyInjection] removed the unused Reference and Parameter classes use statements from the compiled container class

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | ~
| License       | MIT
| Doc PR        | ~

Commits
-------

7730d8d [DependencyInjection] removed the unused Reference and Parameter classes use statements from the compiled container class
bug #9516 [AclProvider] Fix incorrect behavior when partial results returned from cache (superdav42)

This PR was merged into the 2.2 branch.

Discussion
----------

[AclProvider] Fix incorrect behavior when partial results returned from cache

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #9515
| License       | MIT
| Doc PR        | none

[AclProvider] Fix incorrect behavior when partial results returned from cache

findAcls wasn't throwing the NotAllAclsFoundException with the partial result when some acls were retrieved from the cache. This will fix that behavior. Ideally we would update it to cache items that were not found so it wouldn't have to query the db every time for non existent items, but I'm not sure if that is possible.
I'm not sure if the ACL cache is being used very much, I didn't find any docs about it but it seems to work except for this issue. It might be more appropriate to merge the fix in master if no one is relying on it to work in 2.2.

Commits
-------

edae59c [AclProvider] Fix incorrect behaviour when partial results returned from cache