KFSCNTRB-2039 Corrected some CAB logic and added comments,We need to ensure that Capital Asset Informations aren't,taken from their document during filtering!
KFSCNTRB-2039- fixing compilation error caused by previous commits to the service
KFSCNTRB-2039 Correcting correction.,I'm not sure when the CAB NoOp is used, but it seems that it should,do nothing rather than suck up the capital asset informations.
KFSCNTRB-2039 Normalizing line endings,The next commit will be much easier to read if the line endings,are normal before I make that commit.,Many of the files in the repo have unregular line endings. It looks,like all the files had two-byte line endings, then someone went through,and updated the copyright date and made the copyright line only have,a one-byte line ending.
KFSCNTRB-2039 Adding unit test for error,Adding a unit test to ensure that organization reference id is used,to match a capital asset information with a general ledger entry.,I also added some comments to the target of the test.
KFSCNTRB-2039 Corrected use of org ref id.,We had earlier identified the missing equality of organization reference id, but,it was subsequently discovered that, when this value is not provided, it can here,be null and there be an empty string. I tried to track down where it was being,converted from null to an empty string and found that, as a SourceAccountingLine,,the value is null. This is converted into a pending entry somewhere around,AccountingDocumentBase.java:682 (where the GLPESD is a SourceAccountingLine). That,is then used to create a OriginEntryFull (OriginEntryFull.java:905) and null is,still preserved. I don't understand the scrubber or poster, but I think they,do some serialization to a file, and my suspicion is that when the lines are,deserialized, they are set to an empty string rather than null.,I don't think it's feasible to correct this behaviour (by adding a new,serialization convention of, what, "<null>" for null values), so the current,commit represents a workaround that treats null and empty string equivalently,as it touches organization reference id.