Remove successes and failures

No reason to store them and they could fill a ton of unnecessary memory.
And remove specs referencing obsolete accessors
Description/whitespace changes (minor)

Four modules updated for the weekly release with minor cosmetic fixes.

- [ ] See all affected modules still load.
- [ ] See all affected modules have expected `info`
Add private_type and realm_key accessors
Merge branch 'feature/MSP-10648/login-scanner-creation' into feature/MSP-10656/unify-ssh-scanners
Axe SSHKey in favor of a unified SSH
Unify SSH specs as well
Merge pull request #3500 from todb-r7/fixup-release

Release fixup: Description/whitespace changes (minor)
Merge pull request #95 from rapid7/feature/MSP-10649/remove-successes

Remove successes and failures
Update to compatible dependencies

MSP-10654
make private_type validation conditional

there are times when this won't be filled in
but the credential is still valid
Merge pull request #96 from rapid7/feature/MSP-10657/add-private-type

Add private_type and realm_key accessors to Framework::Credential
Mid-work commit

MSP-9848
Merge pull request #94 from rapid7/feature/MSP-10648/login-scanner-creation

Feature/msp 10648/login scanner creation
Merge branch 'staging/electro-release' into feature/MSP-10656/unify-ssh-scanners
Merge pull request #97 from rapid7/feature/MSP-10656/unify-ssh-scanners

Feature/msp 10656/unify ssh scanners
Merge branch 'master' into staging/electro-release

Conflicts:
	Gemfile
	Gemfile.lock
updating dependencies

metasploit-credential to pre.electro.pre.release
metasploit-data-models to 0.18.0

MSP-10654
Merge branch 'bug/MSP-10654/compatibility' into staging/electro-release
fix to_credential on core

the Metasploit::Credential::Core to_credential
method now seats private_type and realm_key correctly