Add -Xlint -Xfatal-warnings

for lots of clean code goodness.
It's likely because the first line is a managed(....) which differs from
the Try(...) enough to confuse scalac.  Sigh.

On Fri, Nov 21, 2014 at 7:23 PM, urmilan <notifications@github.com> wrote:

> In src/main/scala/com/socrata/geospace/GeospaceServlet.scala:
>
> >      val readTime = System.currentTimeMillis - readReprojectStartTime
> >      logger.info("Decompressed shapefile '{}' ({} milliseconds)", friendlyName, readTime);
> >
> > -    readResult match {
> > -      case Success((features, schema)) =>
> > -        val ingressStartTime = System.currentTimeMillis
> > -        val ingressResult =
> > -          for { response <- FeatureIngester.ingestViaCoreServer(requester, sodaFountain, friendlyName, features, schema) }
> > -          yield {
> > -            val ingressTime = System.currentTimeMillis - ingressStartTime
> > -            logger.info("Reprojected and ingressed shapefile '{}' to domain {} : (resource name '{}', {} rows, {} milliseconds)",
> > -                        friendlyName, domain, response.resourceName, response.upsertCount.toString, ingressTime.toString);
> > -            Map("resource_name" -> response.resourceName, "upsert_count" -> response.upsertCount)
> > -          }
> > +    val (features, schema) = readResult.get
> > +    val ingressStartTime = System.currentTimeMillis
> > +    val ingressResult =
> > +      for { response <- FeatureIngester.ingestViaCoreServer(requester, sodaFountain, friendlyName, features, schema) }
>
> So you can use a for comprehension here but not above? I don't get it...
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/socrata/geospace/pull/33/files#r20754255>.
>



-- 
Evan Chan   |   Principal Engineer, Socrata     |    @evanfchan
*Socrata <http://www.socrata.com/> *| The Data Experience Company™
*Socrata isn't about worldly success, but about changing the world
successfully. This is why I'm excited to be here.*
*What does Socrata do? <https://www.youtube.com/watch?v=yyz86MlkriQ> *(watch
our 2 min video)