Review class identity getters/setters for non-cloned Date objects:
- Date is mutable so we should clone it in getters and setters
- Document why we clone it
- At places where it is already cloned, remove wrongly documented reason of "to prevent duplicate usage of db4o-stored objects" - Date is a db4o-primitive such as int, String, etc - so this does not apply.
- This is part of resolving https://bugs.freenetproject.org/view.php?id=6074
Review class OwnIdentity getters/setters for non-cloned Date objects:
- Date is mutable so we should clone it in getters and setters
- Document why we clone it
- At places where it is already cloned, remove wrongly documented reason of "to prevent duplicate usage of db4o-stored objects" - Date is a db4o-primitive such as int, String, etc - so this does not apply.
- This is part of resolving https://bugs.freenetproject.org/view.php?id=6074
Review class Trust getters/setters for non-cloned Date objects:
- Date is mutable so we should clone it in getters and setters
- Document why we clone it
- At places where it is already cloned, remove wrongly documented reason of "to prevent duplicate usage of db4o-stored objects" - Date is a db4o-primitive such as int, String, etc - so this does not apply.
- This is part of resolving https://bugs.freenetproject.org/view.php?id=6074
Inline getter so we don't clone it twice:
- We did activateFully() so no activation is needed here.
Review class Score getters/setters for non-cloned Date objects:
- Date is mutable so we should clone it in getters and setters
- Document why we clone it
- At places where it is already cloned, remove wrongly documented reason of "to prevent duplicate usage of db4o-stored objects" - Date is a db4o-primitive such as int, String, etc - so this does not apply.
- This is part of resolving https://bugs.freenetproject.org/view.php?id=6074
- In Score.clone(), don't clone date twice where possible. Also, activateFully() is needed because we don't activate there and we need all fields of the class in clone() anyway.
Review class IntroductionPuzzle getters/setters for non-cloned Date objects:
- Date is mutable so we should clone it in getters and setters
- Document why we clone it
- This is part of resolving https://bugs.freenetproject.org/view.php?id=6074