finalise?
knock_code: add sysfs