There's no reason to save the options since they are directly tied to the
DataSet objects and we should get them from said objects every time in
order to prevent any inconsistencies due to bad state.

--
Steve Nguyen
Drexel University - Computer Science
st.nguyen09@gmail.com
(484) 602-5138
On Mar 15, 2014 8:33 PM, "seanblue" <notifications@github.com> wrote:

> In Source/models/Property/GlyphSize/ScaledGlyphSizeScheme.js:
>
> > +           var undef = (value === undefined);
> > +           var validSelection = false;
> > +           if (defined(this._options) && this._options.length > 0) {
> > +               validSelection = (this._options.indexOf(value) !== -1);
> > +           }
> > +
> > +           return undef || validSelection;
> > +        };
> > +
> > +        this.dataSet.isValidValue = isValidValue;
> > +        this.dataField.isValidValue = isValidValue;
> > +    };
> > +
> > +    ScaledGlyphSizeScheme.prototype.getState = function(){
> > +        var state = {
> > +            dataSet: this.dataSet.getState().value,
>
> So maybe I miscommented before. This variable called dataSet is an
> ArrayProperty. Is there any reason this shouldn't be saving the optionspart? If it makes sense not to, maybe we should decide if it's necessary at
> all for ArrayProperty to save the options.
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/KSHSK/WAVED/pull/143/files#r10637377>
> .
>