Revert accidental submodule change

Signed-off-by: Joseph Palermo <jpalermo@pivotallabs.com>
New association matchers used for all of runtime models

[#72664052]

Signed-off-by: Joseph Palermo <jpalermo@pivotallabs.com>
Respect max attempts for all jobs

- respect max attempts
- require max attempts on all jobs
- change default max attempts to 3

[#68405906]

Signed-off-by: Eric Malm <emalm@pivotallabs.com>
Allow failures to occur at least once

If a local file is missing, allow the error to occur once and then stop the
job.

[#68405906]

Signed-off-by: Matthew Sykes <matthew.sykes@gmail.com>
New association matchers used for all service models

- it_behaves_like "a CloudController model" has not been removed

[#72664052]
Allow destination to be a range of IP addresses for security group rules

* Refactored rule validation for tcp, udp, and icmp into their own classes.

[#71585396,#72741200]
Fix RSpec deprecation warnings

- be_false and be_true changed to "be false" and "be true"
- added "and_record_arguments" for stub objects

[#72486714]
Update to RSpec 3

- Use master of rspec_api_documentation

[#72486690]
Use transpec to remove deprecated RSpec syntax

[#72486690]
Disable RSpec "should" syntax.

Update instafail formatter

[#72486690]
Backfill specs for eager loaded sti association

[#72664052]
Attempt to fix pre-packaging by changing git url
NewRelic can be completely disabled

Prior to this commit, if a NewRelic license key was not provided, the
NewRelic code would still be activated in the cloud controllers and
ancillary jobs.  This code would use a default configuration that could
negatively impact memory consumption since the captured data was queued
and could not be offloaded to the NewRelic servers.

With this commit, NewRelic is enabled only when the cloud controller is
in 'development mode' or NewRelic is explicitly enabled via the
'newrelic_enabled' property in the config.  This new configuraiton
attribute is now used to guard the loading and activiation of NewRelic.

The cloud controller ctl scripts were also updated to explicitly disable
NewRelic when the deployment does not provide a license key or enable
development mode.

[#73626418]

Signed-off-by: Michael Fraenkel <fraenkel@us.ibm.com>
Signed-off-by: Matthew Sykes <matthew.sykes@gmail.com>
Consistent error messages when adding services with existing names

[#72797288]
Backfill tests for name+space uniqueness validation in ServiceInstance model

[#72797288]
Security Groups can be seeded through the config

* Currently default_staging_security_group
  and default_running_security_group are only
  one security group, but ideally they could be an array.

[#71585396]
Implement All protocols rule for security groups

* Refactor rule validators to inherit from base validator

[#74073900]

Signed-off-by: James Myers <jmyers@pivotallabs.com>
Update travis.yml to support docker workers

[#73211950]

Signed-off-by: Joseph Palermo <jpalermo@pivotallabs.com>
Integration specs don't need database truncation because they don't use the test database

[#73177520]

Signed-off-by: Joseph Palermo <jpalermo@pivotallabs.com>
Remove test pollution detection since we haven't seen any recent evidence of it

[#73177520]

Signed-off-by: Joseph Palermo <jpalermo@pivotallabs.com>