Yes, I'd propose changing to the inline ternary although that's personal
preference. The larger point would simply be that if we have two calls that
are effectively the same (and they are near in other in the code base) we
should make them look the same.


On Thu, Jan 2, 2014 at 2:25 PM, Jason Petersen <notifications@github.com>wrote:

> In contrib/file_fdw/file_fdw.c:
>
> >
> >  	EndCopyFrom(festate->cstate);
> >
> > +	filename_or_program =
> > +			(festate->program != NULL) ? festate->program : festate->filename;
> > +
> >  	festate->cstate = BeginCopyFrom(node->ss.ss_currentRelation,
>
> I don't understand… what change are you proposing here? You want this
> occurrence changed to an inline ternary as here<https://github.com/jasonmp85/postgres/blob/b4f5ceef55999769142c3a87ae3cd2654d21419c/contrib/file_fdw/file_fdw.c#L692>
> ?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/jasonmp85/postgres/pull/3/files#r8625127>
> .
>