Why? Shouldn't we use the patch that tracks the pull request?

On Wednesday, March 12, 2014, Mike McQuaid <notifications@github.com> wrote:

> In Library/Formula/frescobaldi.rb:
>
> > @@ -19,8 +18,14 @@ class Frescobaldi < Formula
> >    depends_on "pkg-config" => :build
> >
> >    resource "python-poppler-qt4" do
> > -    url "https://python-poppler-qt4.googlecode.com/files/python-poppler-qt4-0.16.3.tar.gz"
> > -    sha1 "fe6aa650a1a917caeedd407ae0c428a5de9eefb8"
> > +    url "https://github.com/wbsoft/python-poppler-qt4/archive/v0.18.1.tar.gz"
> > +    sha1 "584345ae2fae2e1d667222cafa404a241cf95a1f"
> > +  end
> > +
> > +  def patches
> > +    # Add my name to the credits as Homebrew formula maintainer.
> > +    # Remove if https://github.com/wbsoft/frescobaldi/pull/391 is accepted.
> > +    'https://github.com/wbsoft/frescobaldi/pull/391.patch'
>
> Let's use https://github.com/wbsoft/frescobaldi/commit/0cce03.patch
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/Homebrew/homebrew/pull/27441/files#r10512185>
> .
>


-- 
Marnen Laibow-Koser
marnen@marnen.org
http://www.marnen.org

Sent from Gmail Mobile