Support specifying Adjustment state for fetch requests

I've made a few small changes to support specifying Adjustment state for fetch requests. 

I also increased the visibility of doGET because with this visibility I would have been able to append the state parameter to a fetch URL without modifying the client code at all. 
I completely understand the hesitation. However do consider that there are
many API parameters that the client doesn't currently support.

For my use-case I needed "state" support for getAccountAdjustments and I've
had a lot of difficulty modifying the client to support that. So even after
jumping through the hoops necessary to fork the client, compile my own
build, and test it - I'm still unable to get my
modified getAccountAdjustments() method working.

Thus I increased the visibility of doGET and I was able to very easily meet
my needs.

I could have used the already exposed "doGETWithFullURL" except that there
was no way to leverage the "baseUrl" going that route.  If you are opposed
to exposing doGET - perhaps consider exposing baseUrl with a getter so that
it can be used in conjunction with doGETWithFullURL.  That combination
would have met my needs without requiring a fork or patch.


On Wed, Jul 9, 2014 at 9:13 PM, Pierre-Alexandre Meyer <
notifications@github.com> wrote:

> In src/main/java/com/ning/billing/recurly/RecurlyClient.java:
>
> > @@ -683,7 +687,7 @@ public Invoice fetchInvoice(final String recurlyToken) {
> >
> >      ///////////////////////////////////////////////////////////////////////////
> >
> > -    private <T> T doGET(final String resource, final Class<T> clazz) {
> > +    public <T> T doGET(final String resource, final Class<T> clazz) {
>
> I understand the convenience of this but it makes me really nervous to
> expose it as part of the API since it's really an implementation detail.
> Besides, what about PUT, POST, etc.?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/killbilling/recurly-java-library/pull/38/files#r14745767>
> .
>



-- 
Eric Simmerman
President | Tempest Strings Enterprises, Inc.
ets@tempeststrings.com
US Tollfree: (888) 568-8585