This fetches a record or list of records of config from the grid. Since the grid can have any number of columns, I could not find a way to have a real domain class over  here.


From: justinedelson [mailto:notifications@github.com]
Sent: Tuesday, March 11, 2014 4:22 AM
To: Adobe-Consulting-Services/acs-aem-commons
Cc: gopal Kalyanaraman
Subject: Re: [acs-aem-commons] Feature/editable grid (#144)


In bundle/src/main/java/com/adobe/acs/commons/configpage/Configurations.java:

> @@ -0,0 +1,9 @@

> +package com.adobe.acs.commons.configpage;

> +

> +import java.util.List;

> +import java.util.Map;

> +

> +public interface Configurations {

> +    public Map<String,String> lookup(String columnName,String keyWord);

> +    public List<Map<String,String>> getList(String columnName, String keyWord);

Could this API use real domain classes instead of all these nested collections? Also, I'm unclear why this class is pluralized. Is it getting me multiple configurations? Again, maybe this is me not understanding the use case.

—
Reply to this email directly or view it on GitHub<https://github.com/Adobe-Consulting-Services/acs-aem-commons/pull/144/files#r10454668>.