ok, looks good lets make the missing tests