Dwight, would it make sense to incorporate a check for line length in the checkstyle script?  Also, would it make sense to send a "style violation warning" message when the style is violated, so people learn to not do it anymore?

Thanks,
Grigore


________________________________
From: Ömer Sinan Aðacan [notifications@github.com]
Sent: Thursday, April 10, 2014 2:03 PM
To: kframework/k
Cc: Rosu, Grigore
Subject: Re: [k] add regular expression pattern matching for ktest (#356)


In src/javasources/KTool/src/org/kframework/ktest/RegexStringMatcher.java:

> +        boolean matches = true;
> +        for (String pattern : patterns.split("\n")) {
> +            Matcher m = Pattern.compile(pattern).matcher(actual);
> +            matches &= m.find();
> +            if (!matches) {
> +                failedRegex = pattern;
> +                failedActual = actual;
> +                break;
> +            }
> +        }
> +        return matches;
> +    }
> +
> +    @Override
> +    public String errorMessage() {
> +        return String.format("Expected result to match regular expression:%n%s%n%nbut found:%n%s%n", failedRegex, failedActual);


This line is 128 chars long... this is not compliant to our coding conventions.

—
Reply to this email directly or view it on GitHub<https://github.com/kframework/k/pull/356/files#r11501532>.