Do what it takes - no reason to stick with incorrect handcoding.

Joakim
26. feb. 2014 16:16 skrev "Andreas Lauser" <notifications@github.com>
følgende:

> In opm/parser/eclipse/EclipseState/Schedule/TimeMap.cpp:
>
> >
> > -    boost::gregorian::date TimeMap::dateFromEclipse(DeckRecordConstPtr dateRecord) {
> > -        static const std::string errorMsg("The datarecord must consists of three values: \"DAY(int)  MONTH(string)  YEAR(int)\".\n");
> > -        if (dateRecord->size() != 3)
> > +    boost::posix_time::ptime TimeMap::timeFromEclipse(DeckRecordConstPtr dateRecord) {
>
> I can fix the tests, but instead of correcting the hand-constructed
> keywords, I'd rather like to change them to use the JSON definitions, i.e.,
> setting the "addDefault" argument of the Parser's constructor to true. Is
> that okay with you or was there a reason for the manual construction?
> (except the 0.01 seconds increase in runtime of the test)
>
> Going offline now - will be back later tonight.
>
> have fun!
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/OPM/opm-parser/pull/129/files#r10083012>
> .
>