Fixes for upstream

minor cleanups which supposed not to change logic, but
make code cleaner.
Do we really care if NULL is somewhere else ? Also I would imagine most
compilers would ignore String NULL = new String("NULL"); ?

Dave Cramer

On 14 September 2014 11:40, Tiramisu Mokka <notifications@github.com> wrote:

> In org/postgresql/core/v2/SimpleParameterList.java:
>
> > @@ -178,6 +178,6 @@ public void setBinaryParameter(int index, byte[] value, int oid) {
> >       * nb: we explicitly say "new String" to avoid interning giving us an object that
> >       * might be the same (by identity) as a String elsewhere.
> >       */
> > -    private final static String NULL_OBJECT = new String("NULL");
> > +    private final static String NULL_OBJECT = "NULL";
>
> I can revert the patch if there is a real reason to use new
> String("NULL"). Otherwise I will submit a pull request to remove the
> comment.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/pgjdbc/pgjdbc/pull/184/files#r17520406>.
>