modals now working