continue on the caching impl
add notes to remind myself