Refactoring thread

Fair warning: this code is not intended to run just yet. As I was refactoring the functions I realized I had questions for Dan and Co. and decided to put them up on github in order to avoid another long email thread. I'll try to tag people in specific comments to make those salient to relevant folks.

What's with the cd['cNNNNN'] notation? is that really necessary? It isn't 
as attractive as just plain cNNNNN.

dan feenberg
617-863-0343

On Mon, 8 Sep 2014, Ilia Kurenkov wrote:

> 
> In translation.py:
> 
> > +    # x02900 = c02900  # IK: for now leaving out
> > +
> > +    return cd
> > +
> > +
> > +def CapGains(cd):
> > +    #Capital Gains
> > + 
> > +    cd['c23650'] = puf_dict['c23250'] + puf_dict['e22250'] + puf_dict['e2
> 3660'] 
> > +    cd['c01000'] = np.maximum(-3000/ cd['sep'], cd['c23650'])
> > +    # feimax = maximum foreign earned income exclusion
> > +    # this variable is problematic: in the SAS code it's defined as an ar
> ray
> > +    # that has 20 members, covering the period of 1993-2013
> > +    # In our current PlanX, however, it's just a one-member array, having
> > +    # only retained the last feimax value from before
> > +    mod_feimax = planX['feimax'][2013-puf_dict['FLPDYR']] * puf_dict['f25
> 55']
> 
> As far as I understood it, the feimax variable is coming from Plan X
> currently. It makes sense that if it were read in from the PUF it should be
> zero. I will make our feimax entry in the Plan X json file the same as it is
> in the SAS code and will resolve all future discrepancies similarly.
> 
> —
> Reply to this email directly or view it onGitHub.[8114261__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcyNTgxMz
> Y5OCwiZGF0YSI6eyJpZCI6NDE2Mjg2NDl9fQ==--0bf5a330cc33d2787041e56642658942e8f
> 16efc.gif]
> 
> 
>