Substitude uses of lists:reverse(L1) ++ L2 with lists:reverse(L1, L2)
Introduce and use a hipe_icode:icode() type
Add specs for exported functions (to shut off a warning) and types in some record fields
Cleanup and make sure warnings are treated as errors
asn1ct_check: Let asn1_error/3 throw its result

Since most calls to asn1_error/3 throw its result, it makes more
sense to let asn1_error/3 itself throw the error tuple. Add the
return_asn1_error/3 to return the error tuple to use when we don't
want to throw it.
asn1ct_check: Remove unreachable clauses handling {identifier,_,_}

A named number list as used for ENUMERATED and INTEGER can never
have an {identifier,...} tuple in its third position like this:

   {'NamedNumber',Id,{identifier,_,_}}

because asn1ct_parser2:parse_NamedNumber/1 will always replace
an identifier tuple with an #Externaluereference{} record.
asn1ct_check: Rewrite error checking for INTEGER and BIT STRING

The error checking code for INTEGER and BIT STRING was broken,
since it built an error tuple that was never returned.

Rewrite the error checking code, sharing most of the code between
INTEGER and BIT STRING. Make sure that we test for both duplicated
names and number, as well as for negative bit numbers for
BIT STRING.

This rewrite will eliminate two dialyzer warnings for unmatched
returns.
asn1ct_check: Clean up error checking for INSTANCE OF

This will also eliminate a dialyzer warning for unmatched returns,
and increase the coverage.
Clean up reporting of errors in IMPORTS
shell_SUITE: Give bs_match_bin_SUITE/1 more time

Compiled with --enable-native-libs, 2 minutes may not be enough
time on a slow computer to finish bs_match_bin_SUITE/1.
prim_file_SUITE: Remove the short 5 seconds timetrap timeout

Several tests cases would typically fail because of a timetrap
timeout on our older test machines running with a Linux kernel
with a lower version than 2.6.30 and the ext3 file system.

In http://lwn.net/Articles/328363/, the author desribes peformance
issues with ext3 that were fixed in 2.6.30.

Since common_test nowadays has a default timetrap timeout, there
is no need to explicitly set a timeout in each test case (except
for prolonging the default timeout).
Attempt to provide more information if a test case fails
match erlang keywords more carefully

Use word boundaries in some regex matching to avoid recognizing words that
begin with keywords as keywords themselves, for example avoid recognizing a
function named catcher as the catch keyword. Add a regression test for this
problem.
Fix comment that differs from code

The comment in the code state that the tree is traversed to the left,
when in fact it is traversed to the right.
cover_SUITE:reconnect/1: Let the other side initiate the disconnect

The reconnect/1 test starts another node and takes down the connection
to it for a while. However, it has been in observed in our daily builds
that sometimes a "spontaneous" re-connection occurs.

I think that it because of the call to rpc:cast/3 which internally
will set the group leader for the remote process to a process on
the test_server node. It seems that sometimes the group_leader/2
call will re-establish the connection. Unfortunately, I have not
been able to force this to happen by inserting delays in the rpc
module, so it it still just an hypothesis.

However, letting the other node do the disconnection does seem to fix
the problem and intuitively that should be safer way to do it because
the group_leader/2 call and the disconnection will be executed
sequentially on the same node instead of concurrently from two
different nodes.
inets: Fix incorrect argument order

Wrong order of arguments in httpc_handler:update_session/4 error
handling code  should not result in bad_argument error making
stack trace unusable.
remove reference to dbg_wx_edit* modules that don't exist
Correct file:set_cwd/1 typespec

file:set_cwd/1 accepts binaries as arguments, however the binaries
must be properly encoded as per file:native_name_encoding/0.

Also update the note under no_translation error to refer that passing
a ISO-latin-1 encoded binary under any unicode file name encoding.
Change telnet logging behaviour

OTP-11690
Get ct_telnet_client to print all data from server to log