more work on controllers