Inlined test molecule creation from MoleculeFactory.java.

Inlined test molecule creation prior to adding more tests for a bug, as recommended in a recent discussion with JWM.
Sounds like a fine idea,

    Mark



From: John May 
Sent: Monday, September 01, 2014 6:24 PM
To: cdk/cdk 
Cc: mbv31602 
Subject: Re: [cdk] Inlined test molecule creation from MoleculeFactory.java. (#53)


In tool/builder3d/src/test/java/org/openscience/cdk/modeling/builder3d/AtomPlacer3DTest.java:

> @@ -92,14 +139,14 @@ public void testFindHeavyAtomsInChain_IAtomContainer_IAtomContainer() throws Exc
>  	
>  	@Test
>  	public void testNumberOfUnplacedHeavyAtoms_IAtomContainer(){
> -	    IAtomContainer ac = MoleculeFactory.makeAlphaPinene();
> +	    IAtomContainer ac = AtomPlacer3DTest.makeAlphaPinene();
I would tend to leave off the static class definition such that this would read IAtomContainer ac = makeAlphaPinene();. Thoughts?

—
Reply to this email directly or view it on GitHub.